Visual glitch: close tab button on dnd with shrink text

[usernamehw]

Issue Type: Bug

Settings:

"workbench.editor.tabSizing": "shrink",

"tab.activeBackground": "#ff6a0015",
"tab.activeBorder": "#ff8f40",
"tab.activeForeground": "#61676c",
"tab.border": "#424d661a",
"tab.hoverBackground": "#ff6a0020",
"tab.inactiveBackground": "#fafafa",
"tab.inactiveForeground": "#9da2a6",
"tab.unfocusedActiveBorder": "#9da2a6",
"tab.unfocusedActiveForeground": "#9da2a6",
"tab.unfocusedInactiveForeground": "#9da2a6",

Trying to dnd tab:

Probably the same is when srarting dnd in default dark+ theme:

VS Code version: Code - Insiders 1.28.0-insider (af36149, 2018-09-20T14:09:20.109Z)
OS version: Windows_NT x64 10.0.17134

[bpasero]

@Dari-K do you want to take this? It is possible that this is a regression from some work we did, though I cannot remember something during this milestone.

[bpasero]

The second issue with the default dark theme is easy to fix, looks like this rule was competing:

.monaco-workbench > .part.editor > .content.dragged-over .editor-group-container.active > .title .tabs-container > .tab.sizing-shrink.dragged-over:not(.active):not(.dragged) > .tab-label::after,
.monaco-workbench > .part.editor > .content.dragged-over .editor-group-container > .title .tabs-container > .tab.sizing-shrink.dragged-over:not(.dragged) > .tab-label::after {
	background: linear-gradient(to left, ${adjustedColorDrag}, transparent) !important;
}

Adding a :not(.active) to the second rule's .editor-group-container fixes it. I am not sure about the other issue when using the rules as outlined in the comment.

[Dari-K]

I'm actually having trouble reproducing it, I saw it once on Light+ just after I switched to it, but it stopped happening shortly afterwards and I haven't been able to get it to happen again.

[bpasero]

Also do not see it anymore, closing.

[usernamehw]

Did you try to reproduce the first bug with the tab theming provided in the issue description?