Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging with smartstep is super slow. #5916

Closed
v-pavanp opened this issue Apr 27, 2016 · 3 comments
Closed

Debugging with smartstep is super slow. #5916

v-pavanp opened this issue Apr 27, 2016 · 3 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded

Comments

@v-pavanp
Copy link

Testing: #4954

  • VSCode Version: 1.1.0-alpha
  • OS Version: Windows10

Steps to Reproduce:

  1. Create Basic nodejs JavaScript express3 project from Visual studio.
  2. Launch VS code and open project folder.
  3. update launch.json and set the value for smartstep:"true" and sourcemap: "true"
  4. Start debugging and verify application behavior.

Note: I tried with all the possible combination of smartstep and sourcemap and observed this behavior when both the properties set to true.

Actual: Debugging is super slow and taking long time to render page.
Expected: Debugging should not be slow down when user enable smartstep.
smartstepdebugissue

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Apr 28, 2016
@isidorn isidorn assigned weinand and unassigned isidorn Apr 28, 2016
@weinand
Copy link
Contributor

weinand commented May 4, 2016

@v-pavanp 'smart step' makes only sense if your project is using source maps and those sourcemaps cover most of the source code of the project. It seems your project is a plain JavaScript project without a single source map. Why would you use 'smart step' in this case? Just to be slower?

@v-pavanp
Copy link
Author

v-pavanp commented May 6, 2016

No, but how about mixed TypeScript and JavaScript projects.

@weinand weinand added this to the Backlog milestone May 22, 2016
@weinand
Copy link
Contributor

weinand commented May 22, 2016

Mixing works fine as long as the JavaScript you are stepping through is reasonable small (for instance because it is just glue code generated by a transpiler).

If you have lots of JavaScript that does not map to some source language, using this option makes you slow because node debug has to single-step through the JavaScript.

So the slowness you are seeing is expected and not a bug.

@weinand weinand closed this as completed May 22, 2016
@weinand weinand removed this from the Backlog milestone May 22, 2016
@weinand weinand added verified Verification succeeded and removed bug Issue identified by VS Code Team member as probable bug labels May 22, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants