Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test TextSearchComplete #59277

Closed
2 tasks done
roblourens opened this issue Sep 25, 2018 · 0 comments
Closed
2 tasks done

Test TextSearchComplete #59277

roblourens opened this issue Sep 25, 2018 · 0 comments

Comments

@roblourens
Copy link
Member

roblourens commented Sep 25, 2018

#55790

Implement a TextSearchProvider. See that a provider can now optionally return a TextSearchComplete object with a limitHit flag, which the provider can use to signal that it hit an internal result maximum. When the flag is set, the yellow warning on the search view should be shown after the search, no matter how many results were actually returned.

https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.proposed.d.ts#L145

Complexity: 3

@roblourens roblourens added this to the September 2018 milestone Sep 25, 2018
@aeschli aeschli removed their assignment Sep 25, 2018
@mjbvz mjbvz removed their assignment Sep 25, 2018
@mjbvz mjbvz closed this as completed Sep 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants