Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow text search providers to show the maxResults indicator after a custom number of results #55790

Closed
roblourens opened this issue Aug 3, 2018 · 0 comments
Assignees
Labels
api-proposal feature-request Request for new features or functionality on-testplan search Search widget and operation issues

Comments

@roblourens
Copy link
Member

Some extensions like Live Share would like to show the yellow maxResults hint in the search view after a lower number of results than our max of 10000.

This could look like

interface ITextSearchResult {
  hitLimit?: boolean;
}

export interface TextSearchProvider {
    provideTextSearchResults(query: TextSearchQuery, options: TextSearchOptions, progress: Progress<TextSearchResult>, token: CancellationToken): Thenable<ITextSearchResult>;
}
@roblourens roblourens added search Search widget and operation issues api-proposal labels Aug 3, 2018
@roblourens roblourens added this to the August 2018 milestone Aug 3, 2018
@roblourens roblourens self-assigned this Aug 3, 2018
@roblourens roblourens added the feature-request Request for new features or functionality label Sep 14, 2018
roblourens added a commit that referenced this issue Sep 18, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-proposal feature-request Request for new features or functionality on-testplan search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

1 participant