Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thin cursor in the beginning of a line #59328

Closed
yzhang-gh opened this issue Sep 25, 2018 · 7 comments
Closed

Thin cursor in the beginning of a line #59328

yzhang-gh opened this issue Sep 25, 2018 · 7 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release editor-rendering Editor rendering issues verified Verification succeeded
Milestone
September Recover...

Comments

@yzhang-gh
Copy link
Contributor

Issue Type: Bug

Open a document, type some words

image

image

VS Code version: Code - Insiders 1.28.0-insider (fe8d9d2, 2018-09-25T05:31:33.193Z)
OS version: Windows_NT x64 10.0.18242

System Info
Item Value
CPUs Intel(R) Core(TM) i5-6200U CPU @ 2.30GHz (4 x 2400)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 7.90GB (3.44GB free)
Process Argv
Screen Reader no
VM 0%
Extensions: none
@vscodebot vscodebot bot added the insiders label Sep 25, 2018
@rebornix
Copy link
Member

@neilsustc do you happen to zoom in/out the editor or change the font size ? It would be great if you can share more information to help troubleshoot.

@rebornix rebornix added the info-needed Issue requires more information from poster label Sep 25, 2018
@yzhang-gh
Copy link
Contributor Author

No zoom (and even no zoomLevel: 0)
Font size 16

@roblourens
Copy link
Member

I see this too, even with no settings. I can show you or debug @rebornix

@rebornix
Copy link
Member

rebornix commented Oct 1, 2018

@roblourens thanks! I got it reproduced. It seems only happening on a high resolution monitor (like retina) I'll see if it's an upstream issue or not.

@rebornix
Copy link
Member

rebornix commented Oct 1, 2018

It's introduced by 5c5e503 which decreases the cursor left position by 1.

@rebornix rebornix assigned alexdima and unassigned rebornix Oct 1, 2018
@rebornix rebornix added editor-rendering Editor rendering issues under-discussion Issue is under discussion for relevance, priority, approach and removed insiders info-needed Issue requires more information from poster labels Oct 1, 2018
@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Oct 8, 2018
@alexdima alexdima added this to the October 2018 milestone Oct 8, 2018
@alexdima alexdima added the candidate Issue identified as probable candidate for fixing in the next release label Oct 9, 2018
@alexdima
Copy link
Member

alexdima commented Oct 9, 2018

The cursor is really difficult to see when indent guides are turned on:

image

@usernamehw usernamehw mentioned this issue Oct 9, 2018
Closed
alexdima added a commit that referenced this issue Oct 10, 2018
@alexdima
Fixes #59328
86671f0
@isidorn
Copy link
Contributor

isidorn commented Oct 11, 2018

Looks great now -> verified
screen shot 2018-10-11 at 16 17 23

@isidorn isidorn added the verified Verification succeeded label Oct 11, 2018
@kieferrm kieferrm mentioned this issue Oct 11, 2018
Closed
30 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release editor-rendering Editor rendering issues verified Verification succeeded
Projects
None yet
Milestone
September Recovery 2018
Development

No branches or pull requests
5 participants
@roblourens @rebornix @isidorn @alexdima @yzhang-gh