Task arguments ignored when quotes inside argument

[sguillia]

Issue Type: Bug

The arguments of my task command are merely ignored whenever there are quotes inside them.

Steps to reproduce

1. Create an executable script that shows the number of arguments that are passed to it.
   I called it show_args.sh

#!/bin/bash
echo Nb args: $#
echo $@

2. Define some task in tasks.json

        {
            "label": "VS Code bug repro",
            "type": "shell",
            "command": [
                "/d/show_args.sh hello \"world\""
            ],
            "problemMatcher": []
        }

3. Run the task

4. See the output

> Executing task: /d/show_args.sh hello "world" <

Nb args: 0

Even the hello argument is ignored.

Remove the quotes around world and the script will work:

> Executing task: /d/show_args.sh hello world <

Nb args: 2
hello world

This bug makes the task feature unusable when quotes are required

VS Code version: Code - Insiders 1.28.0-insider (fe8d9d2, 2018-09-25T05:31:33.193Z)
OS version: Windows_NT x64 10.0.15063

[dbaeumer]

@sguillia which shell (bash) are you using? WSL?

[sguillia]

@dbaeumer if the default task shell is the same as the default integrated terminal shell, then I am using Git Bash.

I have this in settings.json:

"terminal.integrated.shell.windows": "C:\\Program Files\\Git\\bin\\bash.exe"

[dbaeumer]

I am able to reproduce this using the following setup:

tasks.json

{
	"version": "2.0.0",
	"tasks": [
    	{
			"label": "VS Code bug repro",
			"type": "shell",
			"options": {
				"shell": {
					"executable": "C:\\Program Files\\Git\\bin\\bash.exe",
					"args": [
						"-c"
					]
				}
			},
			"command": [
				"./show_args.sh hello \"world\""
			],
			"problemMatcher": []
		}
	]
}

./show_args.sh

#!/bin/bash
echo Nb args: $#
echo $@

Using ' around world works as expected.

@Tyriar here is the shell launch config I use to start the terminal:

Any advice you can give to make this work for " as quotes. In general the data looks good to me.

[Tyriar]

@alexr00 recently made a change in this area and might have an idea what's going on with this case.

[Tyriar]

Possible candidate, marking with September.