Alt+Click on a link in hover is opening workbench html

[sandy081]

Alt+Click on a link in hover is opening workbench html

[sandy081]

I still see this when clicking on some links in latest insiders

Version: b4d09d2

[jrieken]

@sandy081 Did this change make it that insiders?

[sandy081]

I checked it and the above build with version b4d09d2 contains it. I can try again with today's insiders.

[sandy081]

I still see it in latest insiders.

[jrieken]

Yeah, holy smokes me too

[jrieken]

Ok, problem is that #Foo isn't a valid link and that calling URI#parse throws an error. That makes us never call preventDefault...

[jrieken]

@sandy081 please review #59598

[alexr00]

I tested from c432054 and it looks like there's still something wrong with links in hover text. I clicked on the same link in showErrorMessage and nothing appeared to happen. In the console there is an error:

** ERR [UriError]: Scheme is missing: {scheme: "", authority: "", path: "", query: "", fragment: "window.showInformationMessage"}: Error: [UriError]: Scheme is missing: {scheme: "", authority: "", path: "", query: "", fragment: "window.showInformationMessage"}
at file:///C:/Users/alros/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:125:506
at t.e (file:///C:/Users/alros/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:126:340)
at new t (file:///C:/Users/alros/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:127:895)
at Function.e.parse (file:///C:/Users/alros/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:127:155)
at Object.callback (file:///C:/Users/alros/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:1443:748)
at file:///C:/Users/alros/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:253:376
at HTMLDivElement.<anonymous> (file:///C:/Users/alros/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:211:292)**

It's not opening workbench html on alt+click anymore though.

[jrieken]

Yeah, the error is to be expected and tracked here #59469