Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file icons for QuickPickItem #59826

Open
Tracked by #22
aeschli opened this issue Oct 2, 2018 · 6 comments
Open
Tracked by #22

file icons for QuickPickItem #59826

aeschli opened this issue Oct 2, 2018 · 6 comments
Assignees
Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Oct 2, 2018

It would be great if the QuickPickItem also can specify an icon as well as a file icon from the file icon themes.

@RMacfarlane RMacfarlane added feature-request Request for new features or functionality quick-pick Quick-pick widget issues labels Oct 2, 2018
@igorskyflyer
Copy link

+1 for this.

I am aware this is an old and stale feature request but what happened to this? I see it's still open and no further comments have been posted.

@aeschli aeschli changed the title icons for QuickPickItem file icons for QuickPickItem Aug 18, 2021
@aeschli
Copy link
Contributor Author

aeschli commented Aug 18, 2021

We allow a custom TreeView to define a resourceUri for the TreeItem. It that's set the item will get the icon that matches that the given resource.

We should add a similar API for QuickPickItem

@olafurpg
Copy link

I would love to see this feature added. To elaborate on my use-case: I'm working on QuickPick component to open files for a custom FileSystemProvider. The QuickPick component for my file systems is very difficult to use compared to the native Go to file... command because the file extension icons are missing. I have implemented a tree view via TreeDataProvider and it looks and feels almost native thanks to resourceUri.

@mforkel
Copy link

mforkel commented Jun 22, 2022

+1, may be add a property resouceUri to QuickPickItem?

@buenon
Copy link

buenon commented Aug 26, 2022

+1, I've been waiting for this feature for a long time.
My use-case, I'm working on a ScratchPads extension that allows you to open a scratchpad file outside your code keeping your code clean.
When the user wants to open a scratchpad he can select the file type of the file and I'd really like to show the file type icon as well.

@mmgeorge
Copy link

mmgeorge commented Apr 5, 2024

Would love to see this as well, just hit this as part of a QuickPick extension I'm writing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues
Projects
None yet
Development

No branches or pull requests

9 participants