preLaunchTask broken for tasks which take more than 10 seconds

[deitry]

I moved recently from stable to insiders version of vscode and start getting this message 10 seconds after I launch debug with "build" preLaunch task. In stable version my configuration works as expected, even if it takes long time to build project.

Version: 1.28.0-insider
Commit: caaa5369cb4d22b7481e6ff97252cf92937709eb
Date: 2018-09-28T05:17:56.394Z
Electron: 2.0.9
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

Build task:

{
    "version": "2.0.0",
    "tasks": [
        {
            "label": "build",
            "type": "shell",
            "group":{
                "kind": "build",
                "isDefault": true
            },
            "command": "cmake",
            "options": {
                "env": {
                    "CMAKE_CXX_FLAGS": "-Wall -Wextra"
                }
            },
            "args": [
                "--build", "/home/user/workspace/project/build",
                "--config", "Debug",
                "--target", "all",
                "--", "-j4"
            ],
        },
    ]
}

Debug task:

{
    "version": "2.0.0",
    "configurations": [
        {
            "name": "(gdb) Build and run",
            "preLaunchTask": "build",
            "type": "cppdbg",
            "request": "launch",
            "program": "${workspaceFolder}/result/a.out",
            "args": [],
            "stopAtEntry": false,
            "cwd": "${workspaceFolder}",
            "environment": [
                {
                    "name": "LD_LIBRARY_PATH",
                    "value": "/opt/Qt/5.9.1/gcc_64/lib:/usr/local/lib"
                }
            ],

            "externalConsole": false,
            "MIMode": "gdb",
            "setupCommands": [
                {
                    "description": "Enable pretty-printing for gdb",
                    "text": "-enable-pretty-printing",
                    "ignoreFailures": true
                }
            ]
        }
    ]
}

[deitry]

If it matters, I symlinked .vscode-insiders to .vscode in home directory and "Code - Insiders' to "Code" in ~/.config directory in order to preserve all the extensions and settings when moved to Insiders.

[dbaeumer]

@isidorn this sounds like the other bug you investigated. Is this fixed already? Please ping if there is something I need to do.

[isidorn]

@deitry Hi, there was actually a bug I fixed which changes the behavior for you #57346
To be more precise your task is taking longer than 10s to start and for us that is the fall back mechanism when we think the task can not be started.

For now leaving this open and if more users complain about this I can increase the timeout to 20s for example.

[deitry]

@isidorn Hi, thanks for explanation. If it turns to be a feature request, may I ask you to add option to force wait until task is finished?
Build task can take up to 10-20 minutes. :D

[isidorn]

@deitry I wrongly classified this. This is a bug which should be fixed in favor of #57346 since that one is not important.

[isidorn]

@deitry the new insiders will have the fix in 30 minutes. Can you please let us know if this fixes your issue.
I verified this works with my example long running task.

Also thanks a lot for using vscode insiders and for filling issues like this.

[deitry]

@isidorn yeah, it's fixed! Thank you so much

[isidorn]

@deitry thanks for trying it out quickly, adding verified label