Keybinding to focus next terminal does not update terminal dropdown list

[carlocardella]

• VSCode Version:

Version: 1.28.0-insider (user setup)
Commit: 85d970acdee48f6dcecf909a0faeb3c6882217a9
Date: 2018-10-02T22:27:52.997Z
Electron: 2.0.9
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

• OS Version: Windows 10 Pro, 1803

I have added a keybinding to show the precious/next terminal when terminal has focus:

    {
        "key": "ctrl+tab",
        "command": "workbench.action.terminal.focusNext",
        "when": "terminalFocus"
    },
    {
        "key": "ctrl+shift+tab",
        "command": "workbench.action.terminal.focusPrevious",
        "when": "terminalFocus"
    },

The keybinding works as expected, the next or precious terminal is displayed but the dropdown with the list of open terminals is not updated accordingly, so it can be confusing to figure out which terminal is actually selected

powershell terminal

git bash, but the dropdown still shows the previous powershell terminal

If I use the dropdown to switch terminal then everything works as expected: the problem is with the keybinding

Does this issue occur when all extensions are disabled?: Yes

[martellaj]

This isn't a new bug. It's a minor one that I haven't bothered creating an issue for, but finally decided to do it and found this. It's definitely been happening (on Insiders) for at least a week (possibly longer).

[Tyriar]

This only appears to happen on Windows, weird 😕 /cc @cleidigh

[Tyriar]

It also happens when running the command

[Tyriar]

This was introduced by abee50e

[Tyriar]

Fixed in master, keeping open to pull into release/1.28

[cleidigh]

@Tyriar
Thanks.
I think with all your new features of terminal I have to add some more tests for the select box role :-(

[martellaj]

Looks like it's resolved in today's Insiders build! 🎉

[carlocardella]

Yes, it's resolved, thanks 👍

[Guema]

Using AutoLaunch ext and got the same problem without using any shortcut. since last release only (1.28).

AutoLaunched task is displayed in terminal, but dropdown controls keeps bad state

Related ?

[Tyriar]

Merged into release/1.28 with #60545

[ddrrqq]

Good job! I use the Windows 10 1511 version, and I liked to use cmd.
I usually use tsc & web server in tasks.json, sometimes I switch them to view bugs infomation and use git or others, and it not work.
At first, I thought it was my cmd that caused this problem.
I tried a lot of ways to reset cmd settings. 😂

[1020431880]

嗨，程序猿们

[namnguyen6595]

i can't install 'pylint' via pip install. And this is my trouble

[Tyriar]

@0888946595 report that against the python extension https://github.com/Microsoft/vscode-python