Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View: visibility states are redundant #60935

Closed
bpasero opened this issue Oct 15, 2018 · 2 comments
Closed

View: visibility states are redundant #60935

bpasero opened this issue Oct 15, 2018 · 2 comments
Assignees
@bpasero @sandy081
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-state UI state across restarts
Milestone
October 2018

Comments

@bpasero
Copy link
Member

bpasero commented Oct 15, 2018

image

@sandy081 please check the local storage usages in saveVisibilityStates and saveViewsStates
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-state UI state across restarts labels Oct 15, 2018
@bpasero bpasero added this to the October 2018 milestone Oct 15, 2018
@bpasero
Copy link
Member Author

bpasero commented Oct 15, 2018

@sandy081 when fixing it would be great if you could remove the duplicate keys from the object so that we do not migrate these duplicate keys to the new sqlite3 backend.

@sandy081
Copy link
Member

Sure

@bpasero bpasero closed this as completed Oct 16, 2018
bpasero added a commit that referenced this issue Oct 16, 2018
@bpasero
fix #60935
c6c85e3
@bpasero bpasero self-assigned this Oct 16, 2018
bpasero added a commit that referenced this issue Oct 16, 2018
@bpasero
storage - clean up duplicate keys (for #60935)
9d292bc
@mjbvz mjbvz added the verified Verification succeeded label Nov 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-state UI state across restarts
Projects
None yet
Milestone
October 2018
Development

No branches or pull requests
3 participants
@bpasero @sandy081 @mjbvz