Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning icon flickers while changing the json schema setting #62146

Closed
sandy081 opened this issue Oct 30, 2018 · 1 comment
Closed

Warning icon flickers while changing the json schema setting #62146

sandy081 opened this issue Oct 30, 2018 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@sandy081
Copy link
Member

Testing #62087

  • Configure an invalid schema URL for a json file
"json.schemas": [
		{
			"fileMatch": [
				"vscode/sample.json"
			],
			"url": "https://path/to/schema.json",
		},
	]
  • Open sample.json and see warning icon in the status bar
  • Open settings which will remove the warning.
  • Now change the file name to sampl.json
  • Warning is not shown - good
  • Change the file name back to sample.json and save
  • 🐛 Warning icon appears for a moment
@sandy081 sandy081 modified the milestones: November 2018, October 2018 Oct 30, 2018
@joaomoreno joaomoreno removed this from the October 2018 milestone Nov 1, 2018
@aeschli
Copy link
Contributor

aeschli commented Nov 1, 2018

FYI @xxyy... We tested your PR in this weeks test pass. Of course, fixes are welcome, as always. I'm out the coming month, but @octref can help getting them pushed.

@octref octref closed this as completed in 649f448 Nov 2, 2018
octref added a commit that referenced this issue Nov 2, 2018
@octref octref assigned octref and unassigned aeschli Nov 2, 2018
@octref octref added this to the October 2018 milestone Nov 2, 2018
@octref octref added the bug Issue identified by VS Code Team member as probable bug label Nov 2, 2018
@RMacfarlane RMacfarlane added the verified Verification succeeded label Nov 9, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants