Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search improperly matches files inside .git #62409

Closed
elprans opened this issue Nov 1, 2018 · 6 comments
Closed

Search improperly matches files inside .git #62409

elprans opened this issue Nov 1, 2018 · 6 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release search Search widget and operation issues verified Verification succeeded
Milestone
October 2018

Comments

@elprans
Copy link

elprans commented Nov 1, 2018

  • VSCode Version: 1.29.0-insider (4a29bd3)
  • OS Version: Gentoo x64

Steps to Reproduce:

  1. Enable git rerere git config rerere.enabled true
  2. Deal with a merge conflict, git records preimage/postimage for the merge conflict files.
  3. In VSCode, perform a search, and you'll get results from .git/rr-cache even though .git should be completely ignored:

screenshot_20181101_161512

Search log trace:

screenshot_20181101_161541

Not that doing the same search with rg directly does not seem to reproduce the issue:

screenshot_20181101_161649

Does this issue occur when all extensions are disabled?: Yes
@vscodebot vscodebot bot added the insiders label Nov 1, 2018
@elprans
Copy link
Author

elprans commented Nov 1, 2018

Other files like .git/COMMIT_EDITMSG are also included in search.

@elprans elprans changed the title Search improperly matches files inside .git/rr-cache Search improperly matches files inside .git Nov 1, 2018
@kieferrm
Copy link
Member

kieferrm commented Nov 2, 2018

@elprans what do your Search: Exclude and File: Exclude settings look like? If non of them contains **/.git then we'll search inside the .git folder.

@kieferrm
Copy link
Member

kieferrm commented Nov 2, 2018

/needMoreInfo

@elprans
Copy link
Author

elprans commented Nov 2, 2018

@kieferrm Both Search: Exclude and File: Exclude are set to default values:

screenshot_20181101_221527

@elprans
Copy link
Author

elprans commented Nov 2, 2018

Also, in an earlier log screenshot you can see that .git is included in the "excludePattern".

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues labels Nov 2, 2018
@roblourens roblourens added this to the October 2018 milestone Nov 2, 2018
@roblourens roblourens added the candidate Issue identified as probable candidate for fixing in the next release label Nov 2, 2018
@roblourens
Copy link
Member

Yes, the exclude patterns are not respected when searching with a ./ pattern, due to my refactoring this month.

roblourens added a commit that referenced this issue Nov 3, 2018
@roblourens
Fix #62409 - resolve exclude patterns for searchPaths correctly
cba915b
@roblourens roblourens mentioned this issue Nov 4, 2018
Merged
roblourens added a commit that referenced this issue Nov 5, 2018
@roblourens
Fix #62409 - resolve exclude patterns for searchPaths correctly
89f65bd
@octref octref added the verified Verification succeeded label Nov 9, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release search Search widget and operation issues verified Verification succeeded
Projects
None yet
Milestone
October 2018
Development

No branches or pull requests
4 participants
@roblourens @elprans @octref @kieferrm