Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools close when opened while stuff is loading #62719

Closed
jrieken opened this issue Nov 7, 2018 · 4 comments
Closed

DevTools close when opened while stuff is loading #62719

jrieken opened this issue Nov 7, 2018 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Nov 7, 2018

  • run scripts/code.sh
  • reload the window
  • while that happens press cmd+alt+i to open dev tools
  • wait a little and see how dev tools are closed again

this happens because of https://github.com/Microsoft/vscode/blob/362e69ad832813977a97de2ebc89c301fe9f185d/src/vs/platform/menubar/electron-main/menubar.ts#L701-L709

@jrieken
Copy link
Member Author

jrieken commented Nov 7, 2018

it seems like that IPC message is stuck for a long time and only handled late. that's something we should maybe tackle but for this specific case we should know that the command already happened

@bpasero
Copy link
Member

bpasero commented Nov 28, 2018

@jrieken does this still happen? I pushed a change to trigger actions earlier (e.g. not waiting for workbench to have opened all editors). Refs: #63905

@bpasero bpasero added the info-needed Issue requires more information from poster label Nov 28, 2018
@jrieken jrieken removed the info-needed Issue requires more information from poster label Nov 28, 2018
@jrieken
Copy link
Member Author

jrieken commented Nov 28, 2018

Yes - still happens

@bpasero
Copy link
Member

bpasero commented Nov 28, 2018

I see why I am not seeing it because I have F12 assigned as keybinding and that one is not taken by the bootstrap-window.js already. For me the devtools only open when the workbench has started and for you they open right from the beginning but also they close again due to the second delayed invocation...

@bpasero bpasero assigned bpasero and unassigned sbatten Nov 28, 2018
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Nov 30, 2018
@bpasero bpasero added this to the November 2018 milestone Nov 30, 2018
bpasero added a commit that referenced this issue Nov 30, 2018
@mjbvz mjbvz added the verified Verification succeeded label Dec 6, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants