Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property 'isFullScreen' of null #62833

Closed
chrmarti opened this issue Nov 9, 2018 · 3 comments
Closed

Cannot read property 'isFullScreen' of null #62833

chrmarti opened this issue Nov 9, 2018 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@chrmarti
Copy link
Contributor

chrmarti commented Nov 9, 2018

Issue Type: Bug

ERR Cannot read property 'isFullScreen' of null: TypeError: Cannot read property 'isFullScreen' of null
at C.isFullScreen (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:444:954)
at Screen. (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:438:18)
at emitThree (events.js:141:20)
at Screen.emit (events.js:217:7)

VS Code version: Code - Insiders 1.29.0-insider (5438af1, 2018-11-07T00:54:27.213Z)
OS version: Darwin x64 17.7.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 4, 4
Memory (System) 16.00GB (0.89GB free)
Process Argv -psn_0_5215481
Screen Reader no
VM 33%
Extensions (28)
Extension Author (truncated) Version
unique-lines bib 1.0.0
ssh chr 0.0.4
vscode-eslint dba 1.7.0
Spot der 0.4.0
ghlink dt 1.0.2
remotehub eam 0.2.0
EditorConfig Edi 0.12.5
tslint eg2 1.0.40
git-project-manager fel 1.7.1
vscode-pull-request-github Git 0.2.3
rest-client hum 0.20.3
solidity Jua 0.0.46
theme-karyfoundation-themes kar 18.2.1
graphql-for-vscode kum 1.12.1
vscode-azureappservice ms- 0.9.1
vscode-azurefunctions ms- 0.12.0
vscode-cosmosdb ms- 0.8.0
azure-account ms- 0.6.0
azurecli ms- 0.4.2
github-issues-prs ms- 0.9.1
vsliveshare ms- 0.3.925
debugger-for-chrome msj 4.11.0
vscode-docker Pet 0.3.1
vscode-versionlens pfl 0.22.0
vscode-workspacecontains-canary rob 0.0.2
vscode-open-in-github sys 1.8.0
ayu tea 0.16.0
azure-iot-toolkit vsc 1.6.0
@isidorn
Copy link
Contributor

isidorn commented Nov 9, 2018

I could add a null check and simply go over this. However forwarding to @bpasero since this might uncover some flaw in his logic

@isidorn isidorn assigned bpasero and unassigned isidorn Nov 9, 2018
@bpasero bpasero added this to the November 2018 milestone Nov 18, 2018
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug *not-reproducible Issue cannot be reproduced by VS Code Team member as described labels Nov 18, 2018
@vscodebot
Copy link

vscodebot bot commented Nov 19, 2018

We closed this issue because we are unable to reproduce the problem with the steps you describe. Chances are we've already fixed your problem in a recent version of VS Code. If not, please ask us to reopen the issue and provide us with more detail. Our issue reporting guidelines might help you with that.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Nov 19, 2018
@bpasero bpasero reopened this Nov 26, 2018
@bpasero bpasero removed the *not-reproducible Issue cannot be reproduced by VS Code Team member as described label Nov 26, 2018
@bpasero
Copy link
Member

bpasero commented Nov 26, 2018

This was a global listener not being cleaned up when the window closes 👍

@bpasero bpasero closed this as completed Nov 26, 2018
bpasero added a commit that referenced this issue Nov 26, 2018
@roblourens roblourens added the verified Verification succeeded label Dec 6, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants