Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict null check 'completionModel.ts' #63454

Closed
mjbvz opened this issue Nov 19, 2018 · 0 comments
Closed

Strict null check 'completionModel.ts' #63454

mjbvz opened this issue Nov 19, 2018 · 0 comments
Assignees
Labels
engineering VS Code - Build / issue tracking / etc.

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Nov 19, 2018

Part of #60565

Tracks updating ./vs/editor/contrib/suggest/completionModel.ts to have strict null checking

Steps

  1. Add ./vs/editor/contrib/suggest/completionModel.ts to the files section of src/tsconfig.strictNullChecks.json
  2. Run yarn strict-null-check -- --watch
  3. Fix strict null check compiler errors
  4. Verify normal build still works
@mjbvz mjbvz added the engineering VS Code - Build / issue tracking / etc. label Nov 19, 2018
@mjbvz mjbvz added this to the December 2018 milestone Dec 10, 2018
jrieken added a commit that referenced this issue Dec 11, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Development

No branches or pull requests

2 participants