Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrl/cmd + A should select all in lists / trees #63717

Closed
adamroyjones opened this issue Nov 24, 2018 · 8 comments
Closed

ctrl/cmd + A should select all in lists / trees #63717

adamroyjones opened this issue Nov 24, 2018 · 8 comments
Assignees
Labels
feature-request Request for new features or functionality list-widget List widget issues tree-widget Tree widget issues verification-needed Verification of issue is requested verified Verification succeeded

Comments

@adamroyjones
Copy link

I am using vscode 1.29.1 on a mid-2014 MacBook Pro running macOS 10.13.6.

When the file explorer is focussed:

  1. cmd+a does not select all files; and
  2. shift+arrows (to expand a selection) does not behave as it would in Finder.

(Bonus feature request: it'd be really cool if, like in JetBrains' IDEs, typing when the file explorer is focussed would filter the files.)

P.S. Keep up the amazing work—vscode is so good!

@isidorn
Copy link
Contributor

isidorn commented Nov 26, 2018

cmd + a intentionally does not select all, since users expect it to select all in the editor.
@bpasero wasn't that the reason for cmd+a, however I can not get it to select all now when focus is in the explorer

@Docbiz shift + arrows expands the selection for me. Can you provide more details as to what does not behave as expected here? And can you reproduce that behavior with latest vscode insiders https://code.visualstudio.com/insiders/

The bonus feature request is a duplicte - you can find it and upvote it if you want

@isidorn isidorn added the info-needed Issue requires more information from poster label Nov 26, 2018
@bpasero
Copy link
Member

bpasero commented Nov 26, 2018

@isidorn I think now that we have multi-select in the explorer we could allow to select all in lists and trees with Cmd/Ctrl+A.

@isidorn isidorn changed the title Keyboard shortcuts in the file explorer do not work as expected ctrl/cmd + A should select all in lists / trees Nov 26, 2018
@isidorn
Copy link
Contributor

isidorn commented Nov 26, 2018

Yeah, makes sense. Renaming and assigning to next milestone once we have moved to the new tree.
fyi @joaomoreno

@isidorn isidorn added feature-request Request for new features or functionality tree-widget Tree widget issues list-widget List widget issues and removed info-needed Issue requires more information from poster labels Nov 26, 2018
@isidorn isidorn added this to the December 2018 milestone Nov 26, 2018
@adamroyjones
Copy link
Author

adamroyjones commented Nov 26, 2018

@isidorn Thanks for getting back to me!

I've installed the Insiders edition (456e8e64beb2dceac66743959f6802b66e18e300) and have recorded the following video inside it:

tmp

To explain what's going on here: I select 3.txt and start by expanding and contracting my selection by holding down shift. I then start moving the start position for a new selection by using the arrows without holding shift down and create new selections (again, with shift+arrows) that overlap the original ones. It behaves quite unlike selections would in Finder; I don't know if this is intended. (It also might be nice if, when a selection has been created in the file explorer, the return key opened the files rather than started to rename the first file in the selection.)

The bonus feature request is a duplicte - you can find it and upvote it if you want

I would if I could find it! But so long as you know of the idea, then that's fine by me.

Let me know if you need any more information!

@isidorn
Copy link
Contributor

isidorn commented Dec 27, 2018

@Docbiz I see the same with selection, so I would forward this to @joaomoreno as he owns the list / tree selection

@joaomoreno regarding cmd+A not working in the new explorer. The issue here is that this command does not work with the tree. I think it should, so I tried changing it, however I am missing some api. More precisly I can not nicely tell the tree to select all of its elements.
The only way to do it is to traverse all elements via getNode collect them in an array and pass them to setSelection. There should be an easier way for this imho.

@usernamehw
Copy link
Contributor

Would it be possible to use it by folder scopes?
Pressing Cmd+A would select all in folder, next press in the outer ...

Initial state After Cmd+A
before after

@joaomoreno
Copy link
Member

joaomoreno commented Jan 16, 2019

@usernamehw I really like that! Pushed 20b2799

joaomoreno added a commit that referenced this issue Jan 16, 2019
@isidorn
Copy link
Contributor

isidorn commented Jan 16, 2019

Fancy!

@isidorn isidorn added the verification-needed Verification of issue is requested label Jan 28, 2019
@mjbvz mjbvz added the verified Verification succeeded label Jan 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality list-widget List widget issues tree-widget Tree widget issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants