Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Dismiss" X button in the search panel should be aligned to the right edge #63726

Closed
capaj opened this issue Nov 25, 2018 · 4 comments
Closed
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues

Comments

@capaj
Copy link

capaj commented Nov 25, 2018

image

This would ensure predictability. Currently button is aligned just after the text excerpt. Problem is that can be short or long. So this button can be positioned all the way to the right or left, depending on the text size.
I personally suffer from this when I quickly want to click to the search result to see it. Instead I often accidentally click the X button and I remove my result. Then I have to rerun the search again and next time I have to make sure not to click the "Dismiss" button.
Also when you need to remove multiple items using a mouse, it's much more complicated when these buttons are misaligned.

The simple CSS change would make the button position much more predictable.

Version: 1.29.1
Commit: bc24f98
Date: 2018-11-15T19:07:43.495Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

Steps to Reproduce:

  1. Run search
  2. Observe

Does this issue occur when all extensions are disabled?: Yes

@vscodebot vscodebot bot added the search Search widget and operation issues label Nov 25, 2018
@capaj capaj changed the title "Dissmis" X button in the search panel should be aligned to the right edge "Dismiss" X button in the search panel should be aligned to the right edge Nov 25, 2018
@karanisverma
Copy link
Contributor

I would like to contribute on this one!

@roblourens
Copy link
Member

We already have a PR going for this: #63457

@roblourens roblourens added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 27, 2018
@capaj
Copy link
Author

capaj commented Nov 27, 2018

@roblourens that's great. Why isn't the "right" a default then? Any way you look at it, right makes more sense

@sean-mcmanus
Copy link
Contributor

Thanks a lot for fixing this -- I've also been recently plagued by my search results accidentally being dismissed.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

4 participants