Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hovering over SCSS nested @at-root causes an error with the CSS lang server #63805

Closed
abdullahseba opened this issue Nov 26, 2018 · 5 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling verified Verification succeeded
Milestone

Comments

@abdullahseba
Copy link

When hovering over a nested @at-root in scss vscode pops up with the css language server which shows the following:

[Error - 8:46:11 PM] Error while computing hover for file:///c%3A/Users/abdul/Documents/GitHub/theme-pack/src/core/scss/%40abstract/_mixins.scss: Cannot read property 'findAttribute' of null
TypeError: Cannot read property 'findAttribute' of null
    at e.doPrintElement (c:\Program Files\Microsoft VS Code\resources\app\extensions\css-language-features\server\dist\cssServerMain.js:1:550944)
    at e.doPrint (c:\Program Files\Microsoft VS Code\resources\app\extensions\css-language-features\server\dist\cssServerMain.js:1:550741)
    at e.print (c:\Program Files\Microsoft VS Code\resources\app\extensions\css-language-features\server\dist\cssServerMain.js:1:550594)
    at Pn (c:\Program Files\Microsoft VS Code\resources\app\extensions\css-language-features\server\dist\cssServerMain.js:1:553619)
    at e.doHover (c:\Program Files\Microsoft VS Code\resources\app\extensions\css-language-features\server\dist\cssServerMain.js:1:555264)
    at l.runSafe (c:\Program Files\Microsoft VS Code\resources\app\extensions\css-language-features\server\dist\cssServerMain.js:1:71000)
    at Immediate.setImmediate (c:\Program Files\Microsoft VS Code\resources\app\extensions\css-language-features\server\dist\cssServerMain.js:1:96171)
    at runCallback (timers.js:789:20)
    at tryOnImmediate (timers.js:751:5)
    at processImmediate [as _immediateCallback] (timers.js:722:5)

This only happens if @at-root is nested within a mixin or class, and not when its use independently.
It's mostly just annoying as when you move the mouse around, the terminal will switch to the output tab.
Or it pops up if it as already closed.
I have noticed this issue some time ago. it wasn't specific to this version of VSCode.

System info:
Version: 1.29.1 (system setup)
Commit: bc24f98
Date: 2018-11-15T19:13:36.375Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

Steps to Reproduce:

  1. Create an empty scss file.
  2. Add the following:
.test {
    @at-root {
    }
  }
  1. Hover over @at-root.

Does this issue occur when all extensions are disabled?: Yes

@abdullahseba
Copy link
Author

Bad boy bot. Completely unrelated plus dead link.

@octref octref added bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling labels Nov 27, 2018
@octref octref modified the milestones: November 2018, December 2018 Nov 27, 2018
@octref octref modified the milestones: February 2019, March 2019 Feb 25, 2019
@octref octref modified the milestones: March 2019, On Deck Mar 22, 2019
@octref octref modified the milestones: On Deck, May 2019 May 9, 2019
@mjbvz
Copy link
Contributor

mjbvz commented May 28, 2019

This is still broken in insiders.. I suspect that we just need to pick up a new version of vscode-css-languageservice that includes the fix

Adding @aeschli since @octref is out

@mjbvz mjbvz reopened this May 28, 2019
@mjbvz mjbvz added the verification-found Issue verification failed label May 28, 2019
@aeschli
Copy link
Contributor

aeschli commented May 29, 2019

Updated service...

aeschli added a commit that referenced this issue May 29, 2019
@mjbvz
Copy link
Contributor

mjbvz commented May 31, 2019

Closing and marked as verified since the update seems to have fix it in insiders

@mjbvz mjbvz closed this as completed May 31, 2019
@mjbvz mjbvz added verified Verification succeeded and removed verification-found Issue verification failed labels May 31, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants