Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smart select provider api #63935

Closed
jrieken opened this issue Nov 28, 2018 · 3 comments
Closed

Add smart select provider api #63935

jrieken opened this issue Nov 28, 2018 · 3 comments
Assignees
Labels
api api-proposal editor-contrib Editor collection of extras feature-request Request for new features or functionality release-notes Release notes issues smart-select verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Nov 28, 2018

We have expand/shrink selection but it works with a heuristics which has its flaws. Instead, that should be the default but we should also invite extensions authors and language brains to tackle this. Given a syntax tree it should be easy to provide the data we need.

@jrieken jrieken self-assigned this Nov 28, 2018
@jrieken jrieken added feature-request Request for new features or functionality api editor-contrib Editor collection of extras smart-select api-proposal labels Nov 28, 2018
@jrieken jrieken added this to the November 2018 milestone Nov 28, 2018
@jrieken
Copy link
Member Author

jrieken commented Nov 29, 2018

this will help with #4795

@jrieken
Copy link
Member Author

jrieken commented Nov 29, 2018

To make smart select behave consistent we will likely get ast-aware- and default-provider to work hand in hand. #64004 lists sample for default selection ranges. Given that we should merge selection ranges from different providers and I think it's reasonable to do that along containment but not overlap.

@jrieken
Copy link
Member Author

jrieken commented Dec 3, 2018

@jrieken jrieken closed this as completed Dec 3, 2018
@jrieken jrieken added verification-needed Verification of issue is requested release-notes Release notes issues labels Dec 3, 2018
@roblourens roblourens added the verified Verification succeeded label Dec 7, 2018
jrieken added a commit that referenced this issue Dec 18, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api api-proposal editor-contrib Editor collection of extras feature-request Request for new features or functionality release-notes Release notes issues smart-select verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants