-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add smart select provider api #63935
Labels
api
api-proposal
editor-contrib
Editor collection of extras
feature-request
Request for new features or functionality
release-notes
Release notes issues
smart-select
verification-needed
Verification of issue is requested
verified
Verification succeeded
Milestone
Comments
jrieken
added a commit
that referenced
this issue
Nov 28, 2018
this will help with #4795 |
To make smart select behave consistent we will likely get ast-aware- and default-provider to work hand in hand. #64004 lists sample for default selection ranges. Given that we should merge selection ranges from different providers and I think it's reasonable to do that along containment but not overlap. |
jrieken
added a commit
that referenced
this issue
Nov 29, 2018
jrieken
added a commit
that referenced
this issue
Nov 30, 2018
jrieken
added a commit
that referenced
this issue
Dec 3, 2018
jrieken
added a commit
that referenced
this issue
Dec 3, 2018
jrieken
added a commit
that referenced
this issue
Dec 3, 2018
jrieken
added a commit
that referenced
this issue
Dec 17, 2018
jrieken
added a commit
that referenced
this issue
Dec 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api
api-proposal
editor-contrib
Editor collection of extras
feature-request
Request for new features or functionality
release-notes
Release notes issues
smart-select
verification-needed
Verification of issue is requested
verified
Verification succeeded
We have expand/shrink selection but it works with a heuristics which has its flaws. Instead, that should be the default but we should also invite extensions authors and language brains to tackle this. Given a syntax tree it should be easy to provide the data we need.
The text was updated successfully, but these errors were encountered: