Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all lines coming through terminal.onLineData() #64226

Closed
alexr00 opened this issue Dec 3, 2018 · 1 comment
Closed

Not all lines coming through terminal.onLineData() #64226

alexr00 opened this issue Dec 3, 2018 · 1 comment
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal Integrated terminal issues

Comments

@alexr00
Copy link
Member

alexr00 commented Dec 3, 2018

Not all lines are coming through terminal.onLineData(), which is what tasks uses for problem matchers. This means that some tasks won't report or won't clear problems because some of the lines are missing. This does not occur every time, but about 1 in 5 times. Lines missing is more dramatic when debugging since even more lines a missing.

Easy repro in the vscode repo:
Put a break point in the call to terminal.onLineData in terminalTaskSystem.ts
Run the strict null check watch task
Watch the lines that come through. There should be one about Starting incremental compilation, and it will likely be missing.

@alexr00 alexr00 added important Issue identified as high-priority terminal Integrated terminal issues labels Dec 3, 2018
@alexr00 alexr00 added this to the November 2018 milestone Dec 3, 2018
@Tyriar
Copy link
Member

Tyriar commented Dec 3, 2018

duplicate #57803

@Tyriar Tyriar closed this as completed Dec 3, 2018
@Tyriar Tyriar added *duplicate Issue identified as a duplicate of another issue(s) and removed important Issue identified as high-priority labels Dec 3, 2018
@Tyriar Tyriar removed this from the November 2018 milestone Dec 3, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

2 participants