Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/64292 #64365

Merged
merged 2 commits into from Dec 4, 2018
Merged

Fix/64292 #64365

merged 2 commits into from Dec 4, 2018

Conversation

sbatten
Copy link
Member

@sbatten sbatten commented Dec 4, 2018

Missing checks for custom titlebar / native menubar (macOS). I can't actually test this on macOS as I am unable to make it into the office for a few days.

fixes #64292

@sbatten sbatten self-assigned this Dec 4, 2018
@sbatten sbatten requested a review from bpasero December 4, 2018 16:45
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that we do not crash on macOS when running with custom title enabled (running out of sources).

@sbatten sbatten added this to the November 2018 milestone Dec 4, 2018
@sbatten sbatten merged commit 95b5f88 into microsoft:master Dec 4, 2018
@sbatten sbatten deleted the fix/64292 branch December 7, 2018 22:12
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

insider 1.30.0 : UI abnormal
2 participants