-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make menubar its own widget and add overflow #63954
Conversation
Should probably not use More, but rather triple dot icon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the amount of changes, I did not do a code review. I like the direction though, especially making the menubarControl.ts
in workbench slimmer.
Playing around with it (on Linux): I agree we could use a "..." similar to this one:
Though I was actually not opposed to the "More" either.
PS: wow, windows seems to wrap actually (not my preference):
@sbatten there seems to be an issue with the direction of where the menu opens in this case: Since space is typically limited to the right when "More" shows up I believe you need to show the menu then to the left to account for the narrow size, otherwise a user will probably have issues accessing all menu entries from the "More" menu. |
@bpasero thanks for the review, you can see quite a few changes since your approval.
|
@sbatten looks good to me. if you want to merge it for Nov, it should get a good test plan item. |
MenubarControl has been broken into 2 pieces:
This made it very easy to add a the overflow logic as part of the widget
resolves #57756