Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential leak in title control #64470

Closed
mjbvz opened this issue Dec 6, 2018 · 1 comment · Fixed by #64471
Closed

Potential leak in title control #64470

mjbvz opened this issue Dec 6, 2018 · 1 comment · Fixed by #64471
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Dec 6, 2018

Issue Type: Bug

Repo

  1. open an editor.
  2. Keep splitting the editor and then closing the split editors
  3. Repeat a number of times

Bug

[8h7] potential listener LEAK detected, having 197 listeners already. MOST frequent listener (100):

event.ts:96     at ResourceContextKey [as constructor] (file:///Users/matb/projects/vscode/out/vs/workbench/common/resources.js:44:42)
    at create (file:///Users/matb/projects/vscode/out/vs/base/common/types.js:164:14)
    at InstantiationService._createInstance (file:///Users/matb/projects/vscode/out/vs/platform/instantiation/common/instantiationService.js:107:35)
    at InstantiationService.createInstance (file:///Users/matb/projects/vscode/out/vs/platform/instantiation/common/instantiationService.js:76:31)
    at TabsTitleControl.TitleControl [as constructor] (file:///Users/matb/projects/vscode/out/vs/workbench/browser/parts/editor/titleControl.js:52:58)
    at TabsTitleControl [as constructor] (file:///Users/matb/projects/vscode/out/vs/workbench/browser/parts/editor/tabsTitleControl.js:33:32)
    at create (file:///Users/matb/projects/vscode/out/vs/base/common/types.js:164:14)
    at InstantiationService._createInstance (file:///Users/matb/projects/vscode/out/vs/platform/instantiation/common/instantiationService.js:107:35)
    at InstantiationService.createInstance (file:///Users/matb/projects/vscode/out/vs/platform/instantiation/common/instantiationService.js:76:31)
    at EditorGroupView.createTitleAreaControl (file:///Users/matb/projects/vscode/out/vs/workbench/browser/parts/editor/editorGroupView.js:321:73)
    at EditorGroupView.create (file:///Users/matb/projects/vscode/out/vs/workbench/browser/parts/editor/editorGroupView.js:147:18)
    at EditorGroupView [as constructor] (file:///Users/matb/projects/vscode/out/vs/workbench/browser/parts/editor/editorGroupView.js:69:19)
    at create (file:///Users/matb/projects/vscode/out/vs/base/common/types.js:164:14)
    at InstantiationService._createInstance (file:///Users/matb/projects/vscode/out/vs/platform/instantiation/common/instantiationService.js:107:35)
    at InstantiationService.createInstance (file:///Users/matb/projects/vscode/out/vs/platform/instantiation/common/instantiationService.js:76:31)
    at Function.EditorGroupView.createNew (file:///Users/matb/projects/vscode/out/vs/workbench/browser/parts/editor/editorGroupView.js:77:41)
    at EditorPart.doCreateGroupView (file:///Users/matb/projects/vscode/out/vs/workbench/browser/parts/editor/editorPart.js:447:63)
    at EditorPart.doAddGroup (file:///Users/matb/projects/vscode/out/vs/workbench/browser/parts/editor/editorPart.js:421:37)
    at EditorPart.addGroup (file:///Users/matb/projects/vscode/out/vs/workbench/browser/parts/editor/editorPart.js:414:30)
    at Object.splitEditor (file:///Users/matb/projects/vscode/out/vs/workbench/browser/parts/editor/editorCommands.js:355:43)
    at SplitEditorAction.BaseSplitEditorAction.run (file:///Users/matb/projects/vscode/out/vs/workbench/browser/parts/editor/editorActions.js:68:30)
    at file:///Users/matb/projects/vscode/out/vs/workbench/common/actions.js:80:59
    at <anonymous>

VS Code version: code-oss-dev 1.30.0 (Commit unknown, Date unknown)
OS version: Darwin x64 18.2.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 16.00GB (0.02GB free)
Process Argv .
Screen Reader no
VM 18%
mjbvz added a commit to mjbvz/vscode that referenced this issue Dec 6, 2018
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Dec 6, 2018
@bpasero bpasero added this to the November 2018 milestone Dec 6, 2018
bpasero added a commit that referenced this issue Dec 6, 2018
@bpasero
Copy link
Member

bpasero commented Dec 6, 2018

I found another one in explorer view.

@mjbvz mjbvz added the verified Verification succeeded label Dec 7, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants