Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable leak listener for stable build #64493

Closed
jrieken opened this issue Dec 6, 2018 · 0 comments
Closed

Disable leak listener for stable build #64493

jrieken opened this issue Dec 6, 2018 · 0 comments
Assignees
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Dec 6, 2018

We have the leak listener in place and the question if we (1) disable it for the stable build or (2) make it more lightweight. Currently, it always captures the current stack when registering a listener. This cost around 0.1-1ms and takes up some storage. Also, not sure about the value of listener leak warning in the console of stable build. We could

  • leave it as is
  • disable it for stable
  • have a simpler version, like Node.js, which only shows a count once
@jrieken jrieken self-assigned this Dec 6, 2018
@jrieken jrieken added this to the November 2018 milestone Dec 6, 2018
@jrieken jrieken closed this as completed Dec 6, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant