Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Auto Find In Selection" breaks "Find Next Selection" #64513

Closed
adymoussa opened this issue Dec 6, 2018 · 6 comments
Closed

"Auto Find In Selection" breaks "Find Next Selection" #64513

adymoussa opened this issue Dec 6, 2018 · 6 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-find Editor find operations under-discussion Issue is under discussion for relevance, priority, approach

Comments

@adymoussa
Copy link

adymoussa commented Dec 6, 2018

  • VSCode Version: 1.29.1
  • OS Version: Windows 10 Pro, 64 bit, Version 10.0.17134 Build 17134

Enabling "Auto Find In Selection" will make "Find Next Selection" useless, as it will only search in the selected text. I would like to be able to select a word and invoke "Find Next Selection" to jump to the next occurence without having to disable "Auto Find In Selection".

Steps to Reproduce:

  1. Set editor.find.autoFindInSelection to true
  2. Select a word.
  3. Invoke "Find Next Selection"

I expect it to jump to the next occurence.
But due to "Auto Find In Selection" the cursor will stay where it is.

Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Dec 6, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the editor-find Editor find operations label Dec 6, 2018
@MZachmann
Copy link

Adding a vote for this annoying artifact.
Using autoFindInSelection is natural and important but the world's most common action is to highlight a word and click ^F to find it. Not only does the selection button go on (which is ridiculous given that the entry in the field is the selection) but it sticks on so if you un-highlight the selection it still insists the string isn't found.

@namleasia
Copy link

namleasia commented Jul 23, 2019

Suggess: Auto Find In Selection should be auto turned on only if multiline have been selected.
Please vote this #77805

@rebornix rebornix added the under-discussion Issue is under discussion for relevance, priority, approach label Aug 2, 2019
@rebornix
Copy link
Member

Let's use #27083 to track this issue, the solution will be introducing a richer findInSelection option.

@rebornix rebornix added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 23, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 23, 2019

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Oct 23, 2019
@Spongman
Copy link

i don't think there's a need for a different findInSelection option.

It never makes sense to 'find in selection' if the find input is initialized with the value of the selection. there's no need for an option to say 'always do something that never makes any sense', just don't do the broken thing.

visual studio proper has always done the right thing here, choosing 'current document' instead of 'selection' when doing a ctrl-f3.

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-find Editor find operations under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

5 participants