Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find In Selection should be turned on only if multiline have been selected #77805

Closed
namleasia opened this issue Jul 23, 2019 · 2 comments
Closed

Find In Selection should be turned on only if multiline have been selected #77805

namleasia opened this issue Jul 23, 2019 · 2 comments
Assignees
@rebornix
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-find Editor find operations under-discussion Issue is under discussion for relevance, priority, approach

Comments

@namleasia
Copy link

namleasia commented Jul 23, 2019 •
edited

Enabled "Auto Find In Selection" in settings.

Currently:
When I select one/some words in one line, hit Ctrl+F, this words will be filled in find field automatically, and "Find in selection" also turned on automatically.

Expected:

  • When I select one/some words in one line, hit Ctrl+F, this words will be filled in find field automatically, but "Find in selection" should not be turned on. "Find in selection" should be turned on only if multiline have been selected.
@vscodebot vscodebot bot added the editor-find Editor find operations label Jul 23, 2019
@namleasia namleasia mentioned this issue Jul 23, 2019
Closed
@rebornix rebornix added the under-discussion Issue is under discussion for relevance, priority, approach label Jul 23, 2019
@rebornix rebornix self-assigned this Jul 23, 2019
@jolleekin
Copy link

I suggest the VS Code team adopt the behavior of the Replace tool in WebStorm. To be specific,

  • If the selected text is an identifier
    • fill the Find text box with the selected text
    • turn off Find in selection
  • If the selected text is not an identifier (contains spaces, delimiters, ...)
    • clear the Find text box
    • turn on Find in selection

@rebornix
Copy link
Member

Let's use #27083 to track this issue, the solution will be introducing a richer findInSelection option.

@rebornix rebornix added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 23, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-find Editor find operations under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rebornix @jolleekin @namleasia