Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strict null check 'vs/workbench/parts/terminal/electron-browser/' #65035

Closed
mjbvz opened this issue Dec 13, 2018 · 0 comments
Closed

strict null check 'vs/workbench/parts/terminal/electron-browser/' #65035

mjbvz opened this issue Dec 13, 2018 · 0 comments
Assignees
Labels
engineering VS Code - Build / issue tracking / etc.

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Dec 13, 2018

Part of #60565

Tracks updating ./vs/workbench/parts/terminal/electron-browser/ files to have strict null checking. The following files are currently eligible:

  • vs/workbench/parts/terminal/electron-browser/terminalInstance.ts
  • vs/workbench/parts/terminal/electron-browser/terminalLinkHandler.ts
  • vs/workbench/parts/terminal/electron-browser/terminalProcessManager.ts

Steps

  1. Add file to the files section of src/tsconfig.strictNullChecks.json
  2. Run yarn strict-null-check -- --watch
  3. Fix strict null check compiler errors
  4. Verify normal build still works
@mjbvz mjbvz added the engineering VS Code - Build / issue tracking / etc. label Dec 13, 2018
Tyriar added a commit that referenced this issue Dec 14, 2018
Tyriar added a commit that referenced this issue Dec 14, 2018
@Tyriar Tyriar added this to the January 2019 milestone Dec 14, 2018
@Tyriar Tyriar closed this as completed in d236bfd Dec 14, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Development

No branches or pull requests

2 participants