-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share fonts across components #66201
Comments
@alexandrudima thoughts on this solution that is leveraging CSS variables: https://github.com/Microsoft/vscode/compare/ben/66201 ? Of course I still can tweak the The advantage of this approach is still that:
Disadvantage:
|
@bpasero This looks good to me. Maybe we can have both a CSS variable and a base class name called |
@alexandrudima thanks will do |
From #65776 (comment)
Instead of components defining their own font rules, we should have one CSS class that components can pick to get a certain font style, e.g. one use case seems to be to use a monospace font in the workbench.
The text was updated successfully, but these errors were encountered: