Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F8 ("next problem") doesn't work correctly when moving into the Settings file #66654

Closed
DanTup opened this issue Jan 17, 2019 · 2 comments
Closed

F8 ("next problem") doesn't work correctly when moving into the Settings file #66654

DanTup opened this issue Jan 17, 2019 · 2 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug editor-contrib Editor collection of extras settings-editor VS Code settings editor issues verified Verification succeeded
Milestone
February 2019

Comments

@DanTup
Copy link
Contributor

DanTup commented Jan 17, 2019

  1. Open your user settings JSON file and make several things invalid
  2. Leave the settings JSON open, but switch to another file
  3. Press F8 - this will jump you to the first problem in the settings JSON file
  4. Press F8 again - nothing happens (expected: go to second problem in file)

This seems to be because the first F8 that takes you to the settings JSON doesn't place focus in there, so pressing F8 again doesn't move you to the next one. If you manually click in the right side of the editor and then press F8, then it works as expected.
@vscodebot vscodebot bot added the editor-contrib Editor collection of extras label Jan 17, 2019
@sandy081 sandy081 self-assigned this Jan 17, 2019
@sandy081 sandy081 added this to the December/January 2019 milestone Jan 17, 2019
@sandy081 sandy081 added settings-editor VS Code settings editor issues bug Issue identified by VS Code Team member as probable bug labels Feb 21, 2019
@sandy081
Copy link
Member

  • Open settings JSON UI editor
  • Have some errors in the settings
  • Open another file
  • F8 should navigate errors in the settings file.

sandy081 added a commit to vldmrkl/vscode that referenced this issue Feb 22, 2019
@sandy081
fix microsoft#66654
501c79c
@DanTup
Copy link
Contributor Author

DanTup commented Feb 25, 2019 •
edited

Fix LGTM in insiders, thanks! 👍

@octref octref added the verified Verification succeeded label Feb 27, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug editor-contrib Editor collection of extras settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
3 participants
@DanTup @octref @sandy081