Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve hover presentation for complex errors #67076

Closed
mjbvz opened this issue Jan 24, 2019 · 9 comments
Closed

Improve hover presentation for complex errors #67076

mjbvz opened this issue Jan 24, 2019 · 9 comments
Assignees
Labels
feature-request Request for new features or functionality languages-diagnostics Source problems reporting on-testplan ux User experience issues
Milestone

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Jan 24, 2019

Error hover is good in representing simple errors. But when it comes to complex and descriptive errors, inline error widget can represent them well. But inline error widget is not discoverable.

  • Ability to navigate to inline error widget from hover.
  • Make hover look good with consistent font for the complete message.
@jrieken jrieken added feature-request Request for new features or functionality languages-diagnostics Source problems reporting ux User experience issues labels Jan 24, 2019
@jrieken
Copy link
Member

jrieken commented Jan 24, 2019

/cc @misolori The idea is to add some clue into the error hovers so that we can hint towards the F8 feature - which is more stable and provides a better reading experience with long error messages

@sandy081 sandy081 added this to the On Deck milestone Jan 28, 2019
@sandy081 sandy081 modified the milestones: On Deck, February 2019 Feb 18, 2019
@sandy081 sandy081 changed the title Click on diagnostics hover to F8 Improve hover presentation for complex errors Feb 18, 2019
@sandy081
Copy link
Member

@jrieken Was there a reason for applying editor font in the hover error message? Currently editor font is applied only for message and not for related information.

@sandy081
Copy link
Member

sandy081 commented Feb 18, 2019

Did following improvements

  • Used default font
  • Increased the width
  • Added Go to Problem and Show Quick Fixes... actions
  • Improved related information rendering

image

image

@mjbvz @misolori @jrieken What do you think?

@sandy081
Copy link
Member

Following are the some examples of hovers and peek error widget after improvements.

image

image

image

@sandy081
Copy link
Member

Added the requested feedback

image

@felixfbecker
Copy link
Contributor

#67076 (comment) looks amazing! This would make my life so much easier.

I see the latest screenshot uses the editor font again, why is that? The error message is prose and the diagnostics panel doesn't use the editor font either, nor do hovers..

@eamodio
Copy link
Contributor

eamodio commented Feb 22, 2019

It looks like the lightbulb and go to problems actions are gone in the most recent insiders -- are they coming back?

@ghost
Copy link

ghost commented Feb 22, 2019

I find the bottom bar really distracting since it's always the first thing I see when hovering over a problem. My preference would be to just have the icons attached to the top right corner or some other position that isn't so prominent.

@sandy081
Copy link
Member

@felixfbecker Using normal or editor font for the error message is under discussion.

@eamodio It is back in the latest insiders

@nealot Keeping it at the bottom because it is easy to click these actions. Keeping it far away from the mouse makes it hard to click them as the hover can disappear when you move away mouse.

sandy081 added a commit to vldmrkl/vscode that referenced this issue Feb 22, 2019
sandy081 added a commit to vldmrkl/vscode that referenced this issue Feb 22, 2019
sandy081 added a commit to vldmrkl/vscode that referenced this issue Feb 22, 2019
sandy081 added a commit to vldmrkl/vscode that referenced this issue Feb 22, 2019
sandy081 added a commit to vldmrkl/vscode that referenced this issue Feb 22, 2019
sandy081 added a commit to vldmrkl/vscode that referenced this issue Feb 22, 2019
sandy081 added a commit to vldmrkl/vscode that referenced this issue Feb 22, 2019
sandy081 added a commit to vldmrkl/vscode that referenced this issue Feb 22, 2019
sandy081 added a commit to vldmrkl/vscode that referenced this issue Feb 22, 2019
sandy081 added a commit to vldmrkl/vscode that referenced this issue Feb 22, 2019
sandy081 added a commit to vldmrkl/vscode that referenced this issue Feb 22, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality languages-diagnostics Source problems reporting on-testplan ux User experience issues
Projects
None yet
Development

No branches or pull requests

5 participants