Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window.zoomLevel causes font's to shift up or down #67288

Closed
drewhamlett opened this issue Jan 28, 2019 · 3 comments
Closed

window.zoomLevel causes font's to shift up or down #67288

drewhamlett opened this issue Jan 28, 2019 · 3 comments
Assignees
Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code) zoom VS Code window zoom issues

Comments

@drewhamlett
Copy link

drewhamlett commented Jan 28, 2019

I've narrowed this down to the zoomLevel setting. It doesn't happen if it's not set.

  • VSCode Version: 1.31.0-insider (and stable)
  • OS Version: MacOS 10.14.2

Steps to Reproduce:

  1. Set "window.zoomLevel": 1 (to increase sidebar size)
  2. Scroll down then back up
  3. Delete a line
  4. Random lines will shift up or down

untitled-2 mov

Does this issue occur when all extensions are disabled?: Yes

I pulled down master of vscode and ran it locally. It seems setting the css property zoom, or transform to zoom the editor makes this go away. Everything in the editor is based off the window zoom level so it messes up a lot of things. Might be helpful

@drewhamlett drewhamlett changed the title window.zoomLevel causes font's to shift around window.zoomLevel causes font's to shift up or down Jan 28, 2019
@drewhamlett
Copy link
Author

drewhamlett commented Jan 30, 2019

Just a heads up. I can't reproduce this in the exploration build with Electron 4. So it happens in Electron 2 and 3.

Version 1.31.0-exploration (1.31.0-exploration)
https://az764295.vo.msecnd.net/exploration/37818ac3597b4afda264b05226b0b77fb8e85f41/VSCode-darwin-exploration.zip

@alexdima alexdima added upstream Issue identified as 'upstream' component related (exists outside of VS Code) zoom VS Code window zoom issues labels Jan 30, 2019
@alexdima
Copy link
Member

alexdima commented Oct 9, 2019

Since we now ship with Electron 4.x, this must be fixed...

@alexdima alexdima closed this as completed Oct 9, 2019
@drewhamlett
Copy link
Author

Yes, not seeing this anymore. Thanks!

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code) zoom VS Code window zoom issues
Projects
None yet
Development

No branches or pull requests

2 participants