Inconsistency in list/tree settings

[sandy081]

Testing #67274

There are couple of list/tree settings those get applied for tree only or lists only or for both.

• workbench.tree.horizontalScrolling - Both lists and trees
• workbench.list.keyboardNavigation - Only for trees (if I am not wrong)

It is confusing what gets applied to tree and lists. We should either have consistent prefixes for both or have specific settings for each but not mixed.

[joaomoreno]

The problem is that workbench.tree.horizontalScrolling already existed. At best we can deprecate it in favor of workbench.list.horizontalScrolling. But that can only happen next month.

[joaomoreno]

@sandy081 Since it's the second time this week I've migrated an issue, I've created a util to getMigratedSettingValue:

3e70d8c#diff-800a35d2b141a47ddf9bb3008ce1fb4e

I couldn't get it simpler than that. Please review and let me know if it's incorrect.

[sandy081]

Looks good.

[sandy081]

@joaomoreno Following are the issue I observed moving from old to new setting and if users have old setting enabled

• UI shows horizontal scrolling disabled, but the trees show horizontal scrolling

• Enabling horizontal scrolling triggers restart even though it is already enabled.

• May be not so important, but the settings file now shows Unknown Configuration Setting for the old setting. May be a deprecation message might be useful?

Let me know if you would like to track these as a separate issue or in this one?

[joaomoreno]

@sandy081 Are configuration contributions allowed to do that?

[sandy081]

Yeah you can add a deprecation message like follows

'problems.autoReveal': {
			'description': Messages.PROBLEMS_PANEL_CONFIGURATION_AUTO_REVEAL,
			'type': 'boolean',
			'default': true,
			'deprecationMessage': 'this is deprecated'
		}

This will not suggest the setting in the intellisense and also show a deprecation warning when used.

[joaomoreno]

@sandy081 c4bb878