Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label in problems panel is slightly clipped when using horizontal scrolling #67498

Closed
roblourens opened this issue Jan 29, 2019 · 7 comments
Closed

Label in problems panel is slightly clipped when using horizontal scrolling #67498

roblourens opened this issue Jan 29, 2019 · 7 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug error-list Problems view verified Verification succeeded
Milestone
March 2019

Comments

@roblourens
Copy link
Member

roblourens commented Jan 29, 2019 •
edited

Testing #67275

  • Enable horizontal scrolling
  • Get a long error in the problems pane
  • Scroll horizontally to see the end of the problem label
  • Even when scrolled all the way to the right, it's slightly clipped

image
@joaomoreno
Copy link
Member

@sandy081 This happens because you may have decorations coming up after the row was first rendered. If so, you should notify the tree that the row's width could have possibly changed, through the updateWidth(element) API.

@joaomoreno joaomoreno removed their assignment Jan 30, 2019
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug error-list Problems view labels Jan 30, 2019
@sandy081 sandy081 added this to the February 2019 milestone Jan 30, 2019
sandy081 added a commit to vldmrkl/vscode that referenced this issue Feb 22, 2019
@sandy081
Fix microsoft#67498
77e4ba3
@gregvanl gregvanl reopened this Feb 26, 2019
@gregvanl
Copy link

Still see clipping as can't scroll far enough.

image

@sandy081
Copy link
Member

@gregvanl Is it when you enable horizontal scrolling?

@sandy081 sandy081 added the verification-found Issue verification failed label Feb 27, 2019
@sandy081
Copy link
Member

Ignore my previous comment, I can repro it.

@sandy081 sandy081 removed the verification-found Issue verification failed label Feb 27, 2019
@sandy081
Copy link
Member

Moving to march as this is not a regression.

@sandy081 sandy081 modified the milestones: February 2019, March 2019 Feb 27, 2019
@sandy081
Copy link
Member

@joaomoreno There are no decorations in the message row other than highlights. So not sure when I have to call updateWidth?

@joaomoreno
Copy link
Member

Make sure the width measured here makes sense.

@roblourens roblourens added the verified Verification succeeded label Mar 27, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators May 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug error-list Problems view verified Verification succeeded
Projects
None yet
Milestone
March 2019
Development

No branches or pull requests
4 participants
@joaomoreno @roblourens @sandy081 @gregvanl