Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging from explorer to Open Editors doesn't work #67883

Closed
roblourens opened this issue Feb 4, 2019 · 1 comment
Closed

Dragging from explorer to Open Editors doesn't work #67883

roblourens opened this issue Feb 4, 2019 · 1 comment
Assignees
@joaomoreno @isidorn
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release file-explorer Explorer widget issues verified Verification succeeded
Milestone
December/January ...

Comments

@roblourens
Copy link
Member

roblourens commented Feb 4, 2019 •
edited

  • Drag a file from the explorer to Open Editors
  • Get error
TypeError: Cannot read property 'moveEditor' of undefined
(anonymous function) (/datadrive/vscode/src/vs/workbench/parts/files/electron-browser/views/openEditorsView.ts:660)
OpenEditorsDragAndDrop.drop (/datadrive/vscode/src/vs/workbench/parts/files/electron-browser/views/openEditorsView.ts:659)
ListViewDragAndDrop.drop (/datadrive/vscode/src/vs/base/browser/ui/list/listWidget.ts:1046)
ListView.onDrop (/datadrive/vscode/src/vs/base/browser/ui/list/listView.ts:864)
(anonymous function) (/datadrive/vscode/src/vs/base/common/event.ts:56)
Emitter.fire (/datadrive/vscode/src/vs/base/common/event.ts:567)
fn (/datadrive/vscode/src/vs/base/browser/event.ts:16)
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues candidate Issue identified as probable candidate for fixing in the next release labels Feb 5, 2019
@joaomoreno joaomoreno added this to the December/January 2019 milestone Feb 5, 2019
joaomoreno added a commit that referenced this issue Feb 5, 2019
@joaomoreno
fixes #67883
105aa58
@joaomoreno joaomoreno mentioned this issue Feb 5, 2019
Merged
@joaomoreno
Copy link
Member

Good catch!

@sandy081 sandy081 added the verified Verification succeeded label Feb 5, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Milestone
December/January 2019
Development

No branches or pull requests
4 participants
@joaomoreno @roblourens @isidorn @sandy081