Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal can crash when resizing both dimensions #67933

Closed
Tyriar opened this issue Feb 5, 2019 · 2 comments
Closed

Terminal can crash when resizing both dimensions #67933

Tyriar opened this issue Feb 5, 2019 · 2 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
January 2019 Reco...

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 5, 2019

xtermjs/xterm.js#1926
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) terminal Integrated terminal issues labels Feb 5, 2019
@Tyriar Tyriar added this to the January Recovery 2019 milestone Feb 5, 2019
@Tyriar Tyriar self-assigned this Feb 5, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Feb 5, 2019

Fixed in master, needs xtermjs/xterm.js#1930 to be pulled into release branch

@Tyriar Tyriar closed this as completed in a9a726a Feb 5, 2019
@Tyriar Tyriar reopened this Feb 7, 2019
@Tyriar Tyriar added the candidate Issue identified as probable candidate for fixing in the next release label Feb 7, 2019
Tyriar added a commit that referenced this issue Feb 7, 2019
@Tyriar
Fix terminal crash when resizing larger in both dimensions
3ce7224 
Fixes #67933
@Tyriar
Copy link
Member Author

Tyriar commented Feb 7, 2019 •
edited

Verification:

  • Open a terminal
  • Resize the sidebar to be > 50% of the screen size
  • Type out a long line in the terminal that wraps several times and press enter (this needs to be able to unwrap when you close the sidebar)
  • Resize the terminal larger, keep moving the cursor and hit cmd/ctrl+b to hide sidebar before you let go. The resize call is debounced every 50ms and you're trying to resize both dimensions larger in a single call. You know you've done the right thing if the text doesn't move/reflow until after you have resized both.

@Tyriar Tyriar mentioned this issue Feb 7, 2019
Merged
Tyriar added a commit that referenced this issue Feb 8, 2019
@Tyriar
Fix a terminal reflow case when both dimensions become smaller
5acd60c 
Part of #67933
@Tyriar Tyriar closed this as completed Feb 9, 2019
Tyriar added a commit that referenced this issue Feb 9, 2019
@Tyriar
vscode-xterm@3.12.0-beta3
fdf21cc 
Fixes #67933
@roblourens roblourens added the verified Verification succeeded label Feb 11, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
January 2019 Recovery
Development

No branches or pull requests
2 participants
@roblourens @Tyriar