Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New file/folder inputs don't disappear if they out of viewport #68339

Closed
Sominemo opened this issue Feb 10, 2019 · 2 comments
Closed

New file/folder inputs don't disappear if they out of viewport #68339

Sominemo opened this issue Feb 10, 2019 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Milestone

Comments

@Sominemo
Copy link

Issue Type: Bug

  • VSCode Version: 1.31.0
  • OS Version: Windows 10 1903 (18329.1)

Steps to Reproduce:

  1. Get a long project tree that doesn't fit in screen and has a scrollbar with multiple folders
  2. Enter a file or folder creation mode by clicking the corresponding icon on project tree toolbar
  3. Scroll the files tree with mouse wheel so the input for new file hides from viewport (doesn't work with scrollbar)
  4. Project tree stays darken-out, click another one folder
  5. Click create new file/folder icon again (doesn't matter which one you chosen before)
  6. Second input appears, in that time previous one stays. Can be repeated few times
  7. As soon as both of inputs get in viewport at the same time they disappear

Does this issue occur when all extensions are disabled?: Yes

2019-02-10_03-15-19

@Sominemo Sominemo changed the title New file/folder inputs don't disappear if the out of viewport New file/folder inputs don't disappear if they out of viewport Feb 10, 2019
@vscodebot vscodebot bot removed the new release label Feb 10, 2019
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues labels Feb 18, 2019
@isidorn isidorn added this to the February 2019 milestone Feb 18, 2019
@isidorn
Copy link
Contributor

isidorn commented Feb 25, 2019

@Sominemo good catch.
@joaomoreno we introduced this regression via 6d6082a
That commit was pushed so we fix when a user New Files on an collapsed folder (previously the blur event would come and destroy the input box).

@joaomoreno However as this issue demonstrates some blur events shuold not be ignored here and am not sure how to fix this. Any ideas?

@isidorn
Copy link
Contributor

isidorn commented Feb 26, 2019

Fixed but caused #69468 which we can investiate tomorrow
@Sominemo thanks for filling this

@RMacfarlane RMacfarlane added the verified Verification succeeded label Feb 27, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants