Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explorer: rename input box doesn't show #69468

Closed
isidorn opened this issue Feb 26, 2019 · 0 comments · Fixed by #69524
Closed

Explorer: rename input box doesn't show #69468

isidorn opened this issue Feb 26, 2019 · 0 comments · Fixed by #69524
Assignees
@joaomoreno @isidorn
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues important Issue identified as high-priority verified Verification succeeded
Milestone
February 2019

Comments

@isidorn
Copy link
Contributor

isidorn commented Feb 26, 2019

  1. Reload workbench
  2. Right click on some folder that has not yet been expanded -> new file
  3. The input box disapears

The issue seems to be that the tree calls dispose twice on the input template, thus making the explorer wrap up.
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues labels Feb 26, 2019
@isidorn isidorn added this to the February 2019 milestone Feb 26, 2019
@isidorn isidorn mentioned this issue Feb 26, 2019
Closed
@RMacfarlane RMacfarlane mentioned this issue Feb 27, 2019
Closed
@joaomoreno joaomoreno changed the title input box not shown if folder not expanded Input box not shown if folder not expanded Feb 27, 2019
@joaomoreno joaomoreno changed the title Input box not shown if folder not expanded Explorer: rename input box doesn't show Feb 27, 2019
@joaomoreno joaomoreno added the important Issue identified as high-priority label Feb 27, 2019
isidorn added a commit that referenced this issue Feb 27, 2019
@isidorn
fixes #69468
63b5fcd
@isidorn isidorn mentioned this issue Feb 27, 2019
Merged
@usernamehw usernamehw mentioned this issue Feb 27, 2019
Closed
@rebornix rebornix added verified Verification succeeded and removed verified Verification succeeded labels Feb 27, 2019
@RMacfarlane RMacfarlane added the verified Verification succeeded label Feb 27, 2019
This was referenced Feb 28, 2019
Closed
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Milestone
February 2019
Development

Successfully merging a pull request may close this issue.

Fix rename input in Explorer microsoft/vscode
4 participants
@joaomoreno @rebornix @isidorn @RMacfarlane