Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breakpoint shown in editor is too high to see the important information #68654

Closed
StephenWeatherford opened this issue Feb 13, 2019 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@StephenWeatherford
Copy link

Issue Type: Bug

When you have break on all exceptions turned on, and it stops at an exception, it's nice that you can see the breakpoint info right in the editor, but frequently the call stack is so long that you see the bottom of the stack and have to scroll up several screens to see anything useful. In the example below, I had to scroll up about 6 full screens (!) to get to the code and top of the call stack. This is especially annoying when you stop at a bunch of expected exceptions from within vscode that you can't do anything about (common when debugging extensions), because you can't just F5 past them without having scrolled up first to figure out what the problem is.

Please display the top of the call stack rather than the bottom. Thanks!

image

VS Code version: Code - Insiders 1.32.0-insider (d18d0ed, 2019-02-11T17:46:35.980Z)
OS version: Darwin x64 18.2.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz (8 x 2500)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 2, 3, 4
Memory (System) 16.00GB (0.02GB free)
Process Argv
Screen Reader no
VM 0%
Extensions (5)
Extension Author (truncated) Version
tslint eg2 1.0.43
vscode-antlr4 mik 2.1.1
vscode-azurestorage ms- 0.5.0
azure-account ms- 0.8.0
vscode-docker Pet 0.5.2
@weinand weinand assigned isidorn and unassigned weinand Feb 14, 2019
@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues bug Issue identified by VS Code Team member as probable bug labels Feb 14, 2019
@isidorn isidorn added this to the February 2019 milestone Feb 18, 2019
@isidorn
Copy link
Contributor

isidorn commented Feb 20, 2019

I limited the height of the stack to 500px. Try it out in Thursday vscode insiders and let us know how it owkrs for you

sandy081 pushed a commit to vldmrkl/vscode that referenced this issue Feb 22, 2019
@roblourens
Copy link
Member

@isidorn it looks like you were already truncating the stack to 10 lines, and this prevents the widget from growing past 500px when the text wraps, is that right?

This helps but it still depends on the size of the editor window. It would be better if we can reveal the top line after showing the exception widget, is that possible at all?

Made up example:

Decent size editor window:

image

Still not a good experience when breaking on exception:
image

@roblourens roblourens reopened this Feb 26, 2019
@roblourens roblourens added the verification-found Issue verification failed label Feb 26, 2019
@isidorn isidorn modified the milestones: February 2019, March 2019 Feb 27, 2019
@isidorn
Copy link
Contributor

isidorn commented Mar 20, 2019

Good catch. Now I am revealing the editor line so the top is always shown

@roblourens roblourens added verified Verification succeeded and removed verification-found Issue verification failed labels Mar 27, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators May 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants