New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression (insiders): Python debugger fails in Fish shell #68997
Comments
This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. Happy Coding! |
Not an extension issue, please reopen this issue. |
@DonJayamanne && isn't supported in fish < v3:
This is a python ext problem. |
@Tyriar the problem is with VSC. |
@DonJayamanne thanks, I thought the command was being generated by the python ext. Sent to @weinand |
This was broken by PR #68435. |
@weinand Need steps for verifying this one. |
Install fish as your shell and then debug any python program on the integrated terminal. |
Thought it's more complex because of the wall of text...Verified. Thanks. |
Thanks, sorry for the wall of logs, was trying to follow the steps precisely, and didn't think to check if I could attached them instead of pasting them where the template told me to. (It was the Python extension issue template, which is probably different than what you're used to in here in core.) Thanks for the fix and verification! |
@rpavlik commented on Tue Feb 19 2019
Environment data
fish version: 2.7.1
Expected behaviour
I should (and used to be able to, possibly as recently as last week) be able to hit F5 and debug a Python script.
Actual behaviour
The process of running the script sources the fish-appropriate virtualenv activate script, if not already done and if configured. Then, it tries running a command line that has a
&&
, which isn't fish syntax (ugh, bugs me as much as it bugs you). Sample command and output:Eventually it ends up with a timeout, as shown in the screen capture below. This did work in the very recent past.
I tried to work around this by launching bash in the terminal before starting the debug session, but it seems to start a new shell in that case.
If I update my
terminal.integrated.shell.linux
to be/bin/bash
instead of/usr/bin/fish
, the same command works just fine, but I would really like to be able to use fish in VS Code in general for interactive use. When searching my settings for "shell" it looks like the Docker extension explicitly launchessh
in this case - might be easier than supporting all the oddball shells out there. Not sure what changed recently to make this no longer work.Steps to reproduce:
terminal.integrated.shell.linux
.. venv/bin/activate.fish
gets put into the terminal automatically.Logs
Output for
Python
in theOutput
panel (View
→Output
, change the drop-down the upper-right of theOutput
panel toPython
)(The default selection here was remote-attach, but it shows nothing.)
Output from
Console
under theDeveloper Tools
panel (toggle Developer Tools on underHelp
; turn on source maps to make any tracebacks be useful by runningEnable source map support for extension debugging
)(I reloaded the window, with no documents open, then just hit F5 to start debugging, to get this trace... If it wasn't the first time I had tried to debug since a window-reload, and I just ran
clear()
before hitting F5, there was only one message shown at the default levels.)If not the first time trying debug in a session, this is all I get.
The text was updated successfully, but these errors were encountered: