Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New File Explorer: not always highlighting active file in the tree #69152

Closed
JosiahWitt opened this issue Feb 21, 2019 · 5 comments
Closed

New File Explorer: not always highlighting active file in the tree #69152

JosiahWitt opened this issue Feb 21, 2019 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Milestone

Comments

@JosiahWitt
Copy link

  • VSCode Version: 1.31.1 (also in insiders build 1550729941)
  • OS Version: Linux x86 (Solus)

Steps to Reproduce:

  1. Open two files (file1 and file2) by double clicking each of them
  2. Click again on the active file in the explorer tree
  3. Switch to the second file by clicking on its tab (you could also use ctrl + p)
  4. The second file is not highlighted in the tree

This changes the behavior from version 1.30.1. In the previous version, the active file would always be highlighted in the explorer. Now, there are some cases, as described previously, where another file is highlighted. This gets confusing with a large project when I glance at the tree and it appears that I'm somewhere else.

This may be partially related to #68597, #68790, and #68747.

Does this issue occur when all extensions are disabled?: Yes

New behavior:
New behavior

Old behavior:
Old behavior

@SetTrend
Copy link

I might have a similar issue:

File Explorer seems to (erroneously) cache a list of some previously opened files.

When I go to Git for VS Code and open a file from there, Explorer doesn't reveal the opened file (which I presume it should). Instead it opens some file I previously opened and already closed again:

fix explorer auto reveal

@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Feb 26, 2019
@isidorn
Copy link
Contributor

isidorn commented Feb 26, 2019

@JosiahWitt great catch. Thanks! Try it out in tomorrow's vscode insiders and let us know if it is better now.

@JosiahWitt
Copy link
Author

@isidorn Thanks! Will do!

@gregvanl gregvanl added the verified Verification succeeded label Feb 26, 2019
@JosiahWitt
Copy link
Author

@isidorn It seems to work great! Thanks!

@isidorn
Copy link
Contributor

isidorn commented Mar 1, 2019

@JosiahWitt thanks for letting us know all is good!

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants