Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow cursor does not expand subtree #69397

Closed
octref opened this issue Feb 25, 2019 · 2 comments
Closed

Follow cursor does not expand subtree #69397

octref opened this issue Feb 25, 2019 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug outline Source outline view issues tree-widget Tree widget issues verified Verification succeeded
Milestone

Comments

@octref
Copy link
Contributor

octref commented Feb 25, 2019

Testing #69299.

  • Have this following scss file:
.bar {
  .baz {

  }
}
  • Have .bar collapsed.
  • Move cursor between .baz
  • Tree won't expand until you click it

This works in stable.

@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug outline Source outline view issues labels Feb 26, 2019
@jrieken jrieken added this to the February 2019 milestone Feb 26, 2019
@jrieken jrieken added the tree-widget Tree widget issues label Feb 26, 2019
jrieken added a commit that referenced this issue Feb 26, 2019
@joaomoreno
Copy link
Member

@roblourens With this change, when you call reveal on a tree item which is in the model but not in the view, I take care of expanding its ancestor path, so you should be able to remove stuff like https://github.com/Microsoft/vscode/blob/877f19187d7c0a3f31367332067182a6d0a0d4f8/src/vs/workbench/contrib/preferences/electron-browser/settingsEditor2.ts#L697

@isidorn Still not there for the async trees, but getting close!

@joaomoreno
Copy link
Member

Fixed by d810435

@octref octref added the verified Verification succeeded label Feb 26, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug outline Source outline view issues tree-widget Tree widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants