-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tree match background theme color #69400
Comments
@octref This is theme dependent. Type filter even exposes special theme keys for this. Which theme are you using? |
I'm using Nord. Which color key are you using for the match box background on the labels? I guess Nord has it set to a color with transparency. |
Hmm we're actually reusing |
Then we'll just create that theme color. |
@joaomoreno Thanks! Make sure you update vscode-docs as well. |
Good call! microsoft/vscode-docs@e92eee5 |
Testing #69299:
I quite like how this used to work:
It's also consistent with IntelliSense:
The new type to filter experience has some contrast problem, as the bg color of list item leaks into bg color of selection range because of transparency).
@joaomoreno I don't know if we are committed to this visual representation of filtering, but I'd suggest something like this (full height, offer 2 them-able colors for filtering, filterSelection fg/bg). This would make it much easier to maintain contrast.
The text was updated successfully, but these errors were encountered: