Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tree match background theme color #69400

Closed
octref opened this issue Feb 25, 2019 · 7 comments
Closed

Add tree match background theme color #69400

octref opened this issue Feb 25, 2019 · 7 comments
Assignees
Labels
feature-request Request for new features or functionality tree-widget Tree widget issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@octref
Copy link
Contributor

octref commented Feb 25, 2019

Testing #69299:

I quite like how this used to work:

image

It's also consistent with IntelliSense:

image

The new type to filter experience has some contrast problem, as the bg color of list item leaks into bg color of selection range because of transparency).

image

@joaomoreno I don't know if we are committed to this visual representation of filtering, but I'd suggest something like this (full height, offer 2 them-able colors for filtering, filterSelection fg/bg). This would make it much easier to maintain contrast.

image

@octref octref changed the title Use Restore the type to filter text highlighting in the old outline view Feb 25, 2019
@octref octref changed the title Restore the type to filter text highlighting in the old outline view Improve contrast for selection text in type to filter Feb 25, 2019
@joaomoreno
Copy link
Member

@octref This is theme dependent. Type filter even exposes special theme keys for this. Which theme are you using?

@octref
Copy link
Contributor Author

octref commented Feb 26, 2019

I'm using Nord. Which color key are you using for the match box background on the labels? I guess Nord has it set to a color with transparency.

@joaomoreno
Copy link
Member

Hmm we're actually reusing findMatchHighlightColor for that.

@octref
Copy link
Contributor Author

octref commented Feb 26, 2019

"editor.findMatchBackground": "#88c0d066" is what Nord is using. This is readable against text editor background, but it's not readable on top of tree focus/select bg.

image

image

If a tree item is selected and tree is in focus, I can't see the type-to-filter box at all:

image

@joaomoreno joaomoreno changed the title Improve contrast for selection text in type to filter Add tree match background theme color Feb 27, 2019
@joaomoreno joaomoreno added feature-request Request for new features or functionality tree-widget Tree widget issues labels Feb 27, 2019
@joaomoreno joaomoreno added this to the March 2019 milestone Feb 27, 2019
@joaomoreno
Copy link
Member

Then we'll just create that theme color.

@joaomoreno joaomoreno modified the milestones: March 2019, Backlog Mar 26, 2019
@joaomoreno joaomoreno modified the milestones: Backlog, October 2019 Oct 9, 2019
jrieken pushed a commit that referenced this issue Oct 21, 2019
@octref
Copy link
Contributor Author

octref commented Oct 21, 2019

@joaomoreno Thanks! Make sure you update vscode-docs as well.

@joaomoreno
Copy link
Member

Good call! microsoft/vscode-docs@e92eee5

@joaomoreno joaomoreno added the verification-needed Verification of issue is requested label Oct 28, 2019
@alexr00 alexr00 added the verified Verification succeeded label Oct 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality tree-widget Tree widget issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants