Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explorer: Enter doesn't collapse focused folder #69574

Closed
usernamehw opened this issue Feb 28, 2019 · 2 comments
Closed

Explorer: Enter doesn't collapse focused folder #69574

usernamehw opened this issue Feb 28, 2019 · 2 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release file-explorer Explorer widget issues verified Verification succeeded
Milestone
February 2019

Comments

@usernamehw
Copy link
Contributor

Issue Type: Bug

VS Code version: Code - Insiders 1.32.0-insider (6924988, 2019-02-27T21:19:19.351Z)
OS version: Windows_NT x64 10.0.17763
@vscodebot
Copy link

vscodebot bot commented Feb 28, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@isidorn isidorn added the candidate Issue identified as probable candidate for fixing in the next release label Mar 1, 2019
@isidorn isidorn added this to the February 2019 milestone Mar 1, 2019
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues labels Mar 1, 2019
isidorn added a commit that referenced this issue Mar 4, 2019
@isidorn
explorer: for collapsing directories react on keydown events
ee8f6b4 
fixes #69574
@isidorn isidorn mentioned this issue Mar 4, 2019
Merged
@isidorn
Copy link
Contributor

isidorn commented Mar 4, 2019

To verify make sure that

  1. On windows and linux enter collapses / expands folders
  2. On mac cmd + down collapses / expands folders

@isidorn isidorn closed this as completed Mar 4, 2019
@RMacfarlane RMacfarlane added the verified Verification succeeded label Mar 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
3 participants
@isidorn @RMacfarlane @usernamehw