Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outline view: no symbols shown after collapse and expand #69667

Closed
gregvanl opened this issue Mar 1, 2019 · 4 comments
Closed

Outline view: no symbols shown after collapse and expand #69667

gregvanl opened this issue Mar 1, 2019 · 4 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release outline Source outline view issues regression Something that used to work is now broken verified Verification succeeded
Milestone
February 2019

Comments

@gregvanl
Copy link

gregvanl commented Mar 1, 2019 •
edited

  • VSCode Version: 1.32.0 804373a
  • OS Version: Windows

Steps to Reproduce:

  1. Have a Markdown file open in the editor (repros for any file type JS, TS)
  2. Expand Outline

Outline view is empty.

  1. Select another file in the editor.

Outline view is filled.

  1. Collapse and expand Outline view.

Outline view is empty.

Also repros if you use View >Open View > Outline from the main menu
@gregvanl
Copy link
Author

gregvanl commented Mar 1, 2019

This is a recent regression and does not repro with the previous 1.32 Insiders build
Commit: 52306b4

@gregvanl gregvanl added candidate Issue identified as probable candidate for fixing in the next release regression Something that used to work is now broken labels Mar 1, 2019
@gregvanl gregvanl added the outline Source outline view issues label Mar 1, 2019
@gregvanl
Copy link
Author

gregvanl commented Mar 1, 2019

Assigning to @jrieken. Bot didn't seem to run.

@jrieken jrieken added this to the February 2019 milestone Mar 4, 2019
@jrieken
Copy link
Member

jrieken commented Mar 4, 2019

A layout call seems to be missing

@jrieken
Copy link
Member

jrieken commented Mar 4, 2019

Nope, layout is always being called when expanding. Everything recovers when resizing things and to make matter worst, it doesn't reproduce when having a breakpoint in layoutBody.

@joaomoreno is there some layout debouncing or does the tree ignore layout calls when the dimensions don't change?

@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Mar 4, 2019
joaomoreno added a commit that referenced this issue Mar 4, 2019
@joaomoreno
fixes #69667
93d176c
@joaomoreno joaomoreno mentioned this issue Mar 4, 2019
Merged
@gregvanl gregvanl added the verified Verification succeeded label Mar 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release outline Source outline view issues regression Something that used to work is now broken verified Verification succeeded
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
2 participants
@jrieken @gregvanl