Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

findFiles never uses default excludes #69875

Closed
roblourens opened this issue Mar 5, 2019 · 0 comments
Closed

findFiles never uses default excludes #69875

roblourens opened this issue Mar 5, 2019 · 0 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release search Search widget and operation issues verified Verification succeeded
Milestone
February 2019

Comments

@roblourens
Copy link
Member

vscode.workspace.findFiles('**/package.json') returns the same results as vscode.workspace.findFiles('**/package.json', null).

The first should have files.exclude applied, the second should have no exclude settings applied.

The exclude parameter in the findFiles API treats null differently from undefined.

Strict null checking extHostWorkspace broke that: 14e4835
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues candidate Issue identified as probable candidate for fixing in the next release labels Mar 5, 2019
@roblourens roblourens added this to the February 2019 milestone Mar 5, 2019
@roblourens roblourens self-assigned this Mar 5, 2019
roblourens added a commit that referenced this issue Mar 6, 2019
@roblourens
Fix #69875
ed1bb03
@roblourens roblourens mentioned this issue Mar 6, 2019
Merged
roblourens added a commit that referenced this issue Mar 6, 2019
@roblourens
Merge pull request #69877 from Microsoft/fix69875
43228c4 
Fix #69875
@RMacfarlane RMacfarlane added the verified Verification succeeded label Mar 6, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release search Search widget and operation issues verified Verification succeeded
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
2 participants
@roblourens @RMacfarlane