Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate keyboard shortcut and preferred modifier when hovering on lightbulb #69976

Closed
mjbvz opened this issue Mar 7, 2019 · 0 comments
Closed

Indicate keyboard shortcut and preferred modifier when hovering on lightbulb #69976

mjbvz opened this issue Mar 7, 2019 · 0 comments
Assignees
@mjbvz
Labels
editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality ux User experience issues verified Verification succeeded
Milestone
October 2019

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Mar 7, 2019 •
edited

Repo
For the js:

//@ts-check
const foo = 1;
food
  1. Place cursor on food to trigger lightbulb

Request

When hovering on the lightbulb for a preferred quick fix, we should indicate what the little blue badge means in the hover message and show the keyboard shortcut for auto fix.
@mjbvz mjbvz added feature-request Request for new features or functionality ux User experience issues verification-needed Verification of issue is requested editor-code-actions Editor inplace actions (Ctrl + .) labels Mar 7, 2019
@mjbvz mjbvz added this to the March 2019 milestone Mar 7, 2019
@mjbvz mjbvz self-assigned this Mar 7, 2019
@mjbvz mjbvz modified the milestones: March 2019, Backlog Mar 25, 2019
@bpasero bpasero removed verification-needed Verification of issue is requested labels May 8, 2019
@mjbvz mjbvz modified the milestones: Backlog, October 2019 Oct 10, 2019
@mjbvz mjbvz closed this as completed in c5d138e Oct 13, 2019
egamma pushed a commit that referenced this issue Oct 14, 2019
@mjbvz @egamma
Show preferred action info in lightbulb hover
664fe8f 
Fixes #69976
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Oct 29, 2019
@connor4312 connor4312 added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Oct 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality ux User experience issues verified Verification succeeded
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
3 participants
@bpasero @connor4312 @mjbvz