Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maximize editor group auto sizing stops working after closing the sidebar #70083

Closed
rbingham opened this issue Mar 8, 2019 · 6 comments · Fixed by #137962
Closed

Maximize editor group auto sizing stops working after closing the sidebar #70083

rbingham opened this issue Mar 8, 2019 · 6 comments · Fixed by #137962
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues verified Verification succeeded
Milestone
January 2023

Comments

@rbingham
Copy link

rbingham commented Mar 8, 2019

When maximizing an editor group and switching between groups, the focused group will maximize. After opening or closing the sidebar, the maximizing stops happening. I have had this happen on linux as well.

Version information

Version: 1.32.1
Commit: 05f146c
Date: 2019-03-08T00:15:00.418Z
Electron: 3.1.3
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Darwin x64 18.2.0

Steps to Reproduce:

  1. Open two tabs and place them in different editor groups
  2. Maximize editor group
  3. Switching between editor groups makes the focused group maximize
  4. Open sidebar
  5. Close sidebar
  6. Switching between editor groups doesn't maximize focused group.

Does this issue occur when all extensions are disabled?: Yes

Gif of bug:

error
@vscodebot
Copy link

vscodebot bot commented Mar 8, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@bpasero bpasero added the layout General VS Code workbench layout issues label Mar 11, 2019
@bpasero bpasero assigned sbatten and unassigned bpasero Mar 11, 2019
@bpasero
Copy link
Member

bpasero commented Mar 11, 2019

@sbatten something to reconsider for the workbench grid, I can reproduce both with the old layout and the new one.

@sbatten sbatten added the bug Issue identified by VS Code Team member as probable bug label Mar 12, 2019
@sbatten sbatten added this to the On Deck milestone Mar 12, 2019
@bpasero
Copy link
Member

bpasero commented Aug 8, 2019

Duplicate of #77901 ?

@rbingham
Copy link
Author

rbingham commented Aug 8, 2019

@bpasero #77901 would be a duplicate of this issue as this one was made back in march.

@sbatten sbatten mentioned this issue Aug 13, 2019
Closed
@Taugeshtu
Copy link

Letting you guys know that it still reproduces on:

Version: 1.43.0
Commit: 78a4c91400152c0f27ba4d363eb56d2835f9903a
Date: 2020-03-09T19:44:52.965Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Linux x64 4.15.0-88-generic

And is still a pain to deal with; to a point where I'm now going to revert to 1.24 after trying out the latest release.

@bpasero bpasero mentioned this issue Mar 16, 2020
Closed
@Cheldon Cheldon mentioned this issue Apr 30, 2020
Closed
@karanssh
Copy link

Bump, I run into this in latest release as well:

Version: 1.58.2
Commit: c3f126316369cd610563c75b1b1725e0679adfb3
Date: 2021-07-14T22:30:16.440Z
Electron: 12.0.13
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: 8.9.255.25-electron.0
OS: Linux x64 5.8.0-59-generic

@sbatten sbatten mentioned this issue Aug 12, 2021
Closed
@sbatten sbatten mentioned this issue Nov 8, 2021
Closed
@ssigwart ssigwart mentioned this issue Nov 27, 2021
Merged
@sbatten sbatten mentioned this issue Feb 21, 2022
Closed
@joaomoreno joaomoreno mentioned this issue Sep 13, 2022
Closed
@joaomoreno joaomoreno mentioned this issue Nov 8, 2022
Closed
@joaomoreno joaomoreno modified the milestones: On Deck, January 2023 Dec 22, 2022
@joaomoreno joaomoreno assigned joaomoreno and unassigned sbatten Dec 22, 2022
joaomoreno added a commit to ssigwart/vscode that referenced this issue Dec 22, 2022
@joaomoreno
splitview: allow custom proportional resize from view
54026f3 
also: keep maximized editor groups, if previously maximized

fixes microsoft#70083
fixes microsoft#137865
joaomoreno added a commit that referenced this issue Dec 22, 2022
@ssigwart @joaomoreno
Retain maximized group size when adding and removing groups or toggli…
6615806 
…ng side bar (#137962)

* Retain maximized group size when adding and removing groups or toggling side bar

* Formatting fix

* Added unit tests

* Use const

* Revert "Use const"

This reverts commit 61f90de.

* Revert "Added unit tests"

This reverts commit 87faa0e.

* Revert "Formatting fix"

This reverts commit 1195fdb.

* Revert "Retain maximized group size when adding and removing groups or toggling side bar"

This reverts commit 13ac1bc.

* splitview: allow custom proportional resize from view

also: keep maximized editor groups, if previously maximized

fixes #70083
fixes #137865

* remove unused imports

Co-authored-by: João Moreno <joao.moreno@microsoft.com>
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 22, 2022
@VSCodeTriageBot VSCodeTriageBot added the insiders-released Patch has been released in VS Code Insiders label Dec 23, 2022
@mjbvz mjbvz added the verified Verification succeeded label Jan 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues verified Verification succeeded
Projects
None yet
Milestone
January 2023
Development

Successfully merging a pull request may close this issue.

Retain maximized group size when adding and removing groups or toggling side bar ssigwart/vscode
8 participants
@joaomoreno @bpasero @Taugeshtu @sbatten @rbingham @mjbvz @karanssh @VSCodeTriageBot