Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugToolbar -> debugToolBar #70954

Closed
isidorn opened this issue Mar 22, 2019 · 2 comments
Closed

debugToolbar -> debugToolBar #70954

isidorn opened this issue Mar 22, 2019 · 2 comments
Assignees
@isidorn
Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues
Milestone
March 2019

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 22, 2019

We are deprecting depricating menu contribution point debug/toolbar in favor of debug/toolBar. That name is more in line with names of other menus.

We will announce this in the release notes and for the following milestone support both.
However in april we will drop support for debug/toolbar

fyi @DanTup @weinand
@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues debt Code quality issues labels Mar 22, 2019
@isidorn isidorn added this to the March 2019 milestone Mar 22, 2019
@isidorn isidorn self-assigned this Mar 22, 2019
@DanTup
Copy link
Contributor

DanTup commented Mar 25, 2019

@isidorn Just to be clear:

  • v1.32 supports only toolbar
  • v1.33 supports both
  • v1.34 support only toolBar

So I should make the change in a version that increases the VS Code requirement to v1.33?

@isidorn
Copy link
Contributor Author

isidorn commented Mar 25, 2019

@DanTup correct!

DanTup added a commit to Dart-Code/Dart-Code that referenced this issue Apr 1, 2019
@DanTup
Change debug/toolbar contribution to debug/toolBar
c09e110 
See microsoft/vscode#70954.
DanTup added a commit to Dart-Code/Dart-Code that referenced this issue Apr 4, 2019
@DanTup
Change debug/toolbar contribution to debug/toolBar
564bf7e 
See microsoft/vscode#70954.
DanTup added a commit to Dart-Code/Dart-Code that referenced this issue Apr 4, 2019
@DanTup
Change debug/toolbar contribution to debug/toolBar
5034e20 
See microsoft/vscode#70954.
@vscodebot vscodebot bot locked and limited conversation to collaborators May 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Milestone
March 2019
Development

No branches or pull requests
2 participants
@DanTup @isidorn