Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http.systemCertificates requires window reload #71228

Open
kieferrm opened this issue Mar 26, 2019 · 1 comment
Open

http.systemCertificates requires window reload #71228

kieferrm opened this issue Mar 26, 2019 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug proxy Issues regarding network proxies
Milestone

Comments

@kieferrm
Copy link
Member

Testing #71108.

Following the steps in the test item, once I'm in a state at which the extension receives data from the server, unchecking http.systemCertificates has no effect. I need to reload the window to make the extension through an error again.

@chrmarti chrmarti added this to the March 2019 milestone Mar 27, 2019
@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug proxy Issues regarding network proxies labels Mar 27, 2019
chrmarti added a commit that referenced this issue Mar 27, 2019
@chrmarti
Copy link
Contributor

On Windows and Mac I'm just adding to the root CAs built-in to Node.js (there seemed to be no good way to read all CAs from the OS). The method of adding CAs appears to store these in a static way, so a window reload becomes necessary to remove them (this is in Node.js native code).

I'm documenting this limitation in the setting's description for now.

@chrmarti chrmarti modified the milestones: March 2019, April 2019 Mar 27, 2019
chrmarti added a commit that referenced this issue Mar 28, 2019
@chrmarti chrmarti modified the milestones: April 2019, May 2019 May 8, 2019
@chrmarti chrmarti modified the milestones: May 2019, Backlog May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug proxy Issues regarding network proxies
Projects
None yet
Development

No branches or pull requests

2 participants